- Issue created by @hussainweb
- 🇮🇳India abhishek_virasat
@hussainweb, as per your point, I tried to install module in Drupal 10. I didn't get any such type error. its proper installed.
- 🇨🇦Canada hussainweb
@abhishek_virasat, did you try recently or are you saying that you were able to install this before I created this issue? I have already fixed this issue but for some reason, the commit doesn't appear here.
- Status changed to Needs review
about 1 year ago 9:56pm 16 October 2023 - Status changed to Active
about 1 year ago 11:24am 17 October 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since there are no patches/MRs to review, the status is still Active.
- Status changed to Needs review
about 1 year ago 1:28pm 17 October 2023 - 🇨🇦Canada hussainweb
@apaderno, like I said in #3, the patch/commit is not visible here but there is still something that needs to be tested, and hence it is set to "Needs Review". From the documentation → :
Note that if a patch is not required in order to complete the idea described in the issue, then it is the idea itself that needs review.
I am interpreting that as there is something here that needs to be reviewed and it is fine for the field to be set that way. I understand it might break your workflow and I don't know of any solution for that.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
A patch is not necessary if it's the project page that needs to be changed. In the case of code, a patch is used to change it.
- Status changed to Needs work
about 1 year ago 1:16pm 23 October 2023 - 🇨🇦Canada hussainweb
I tried this again today and this still needs work. The module is installable on Drupal 10 if you use `Drupal/core` composer package. But not installable if you use `Drupal/core-recommended`.
- 🇨🇦Canada hussainweb
I released a new version of a dependency package that solves the problem for `core-recommended`. I then tested this on Simplytest and this module is installable on Drupal 10. No further change was needed in the module itself.
- Status changed to Fixed
about 1 year ago 1:23pm 23 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.