- Issue created by @segi
- @segi opened merge request.
- Assigned to natts
- Status changed to Fixed
9 months ago 12:31pm 13 October 2023 - 🇬🇧United Kingdom natts London
Thanks for reporting this. I've committed a fix and will release it shortly.
- 🇭🇺Hungary segi
That's was fast :) I just noticed when I wanted to create a MR that my branch two commits behind my branch.
- Issue was unassigned.
- Status changed to Needs work
9 months ago 12:52pm 13 October 2023 - 🇺🇦Ukraine paulrad
Hi, @natts!
A few updates still need to be implemented cause the modulelink_icon_brandswon't be installed.In order for Drupal to know the
link_iconsmodule version you should add a LICENSE.txt file 🐛 Packaging info from .info.yml often creates conflicts when patching Active .Also, take a look at the proper way to mark dependencies → on other contrib modules.
- Assigned to natts
- Status changed to Needs review
9 months ago 3:21pm 13 October 2023 - 🇬🇧United Kingdom natts London
Hi @paulrad, I won't be adding a LICENSE.txt because that's something that drupal.org does itself, using a GNU public license. That issue you've linked to only relates to patching, and it is still active (unresolved), and doesn't say anything about adding a LICENSE.txt file. It suggests that the information be moved to another file that can be added at the same time that the LICENSE.txt file is added, by the drupal.org packaging process.
I've now updated the dependencies in both .info files, thanks.