Link Icons Brands still not D10 compatible

Thanks for reporting this. I've committed a fix and will release it shortly.

That's was fast :) I just noticed when I wanted to create a MR that my branch two commits behind my branch.

Hi, @natts!
A few updates still need to be implemented cause the module link_icon_brands won't be installed.

In order for Drupal to know the link_icons module version you should add a LICENSE.txt file 🐛 Packaging info from .info.yml often creates conflicts when patching Active .

Also, take a look at the proper way to mark dependencies → on other contrib modules.

Hi @paulrad, I won't be adding a LICENSE.txt because that's something that drupal.org does itself, using a GNU public license. That issue you've linked to only relates to patching, and it is still active (unresolved), and doesn't say anything about adding a LICENSE.txt file. It suggests that the information be moved to another file that can be added at the same time that the LICENSE.txt file is added, by the drupal.org packaging process.

I've now updated the dependencies in both .info files, thanks.