Contrib.social

Fix reintroduced bug about Warning: Undefined array key "ip" after 1.0.2

Open on Drupal.org →
Created on 13 October 2023, about 1 year ago

Problem/Motivation

The latest release with the fix from #3175052 → reintroduced the bug that was already fixed in Fix Warning: Undefined array key "ip" in admin_audit_trail.module line 100 → .

The line 'ip' => $log['ip'] ?? '' is now reverted back to 'ip' => $log['ip'].
https://git.drupalcode.org/project/admin_audit_trail/-/commit/995519b86d...

Proposed resolution

Restore the line to 'ip' => $log['ip'] ?? ''

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ✅ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release admin_audit_trail-1.0.3 →

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇺Australia sonnykt Melbourne, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024