TfaTrustedBrowser::validateForm() missing return statement.

Open on Drupal.org →

Created on 12 October 2023, 9 months ago

Updated 7 November 2023, 8 months ago

Problem/Motivation

PHPStan has detected we don't return from TfaTrustedBrowser::validateForm(). This method doesn't appear on initial glance to even be called which may indicate our API needs rework or that we are missing validation somewhere.

We need to determine if we just need to add a constant return, or if our structure needs to change.

Steps to reproduce

Run PHPStan.

Proposed resolution

TBD

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States cmlara

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @cmlara
Comment 9 months ago →
🇺🇦Ukraine paulrad
Can confirm this issue. validateForm is an empty method.
Comment 9 months ago →
🇺🇸United States cmlara
This just opens a much larger set of problems that need to be solved as part of 📌 Convert TFA plugin forms to use subforms Active .

For now I'm just going to add a return TRUE; to the method to clean up the warning to reduce the risk of other faults making it through the CI process.
@cmlara opened merge request.

Comment 9 months ago →

cmlara → committed b95bd6ce on 2.x

Issue #3393464: TfaTrustedBrowser::validateForm() missing return...

Status changed to Downport 9 months ago9:48pm 14 October 2023
Comment 9 months ago →
🇺🇸United States cmlara
First commit to issue fork.
@bhanu951 opened merge request.
Status changed to Needs review 8 months ago12:04pm 7 November 2023
Comment 8 months ago →
🇮🇳India Bhanu951

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024