Bootstrap 5, figure component: default value for figcaption_attributes

Created on 11 October 2023, 9 months ago

Updated 12 October 2023, 9 months ago

Problem/Motivation

Methods are applied without checking if figcaption_attributes exists:

<figcaption{{ figcaption_attributes.addClass('figure-caption') }}>

This is OK for now, because AttributesSettingType::preprocess() is generating empty attributes objects when empty. But this behaviour is a fragile side effect and will disappear with UI Patterns 2.

Proposed resolution

Add a default filter:

<figcaption{{ figcaption_attributes|default(create_attribute()).addClass('figure-caption') }}>

📌 Task

Status

Fixed

Version

5.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.

Merge Requests

!148Bootstrap 5, figure component: default value for figcaption_attributes
Closed
🇫🇷France pdureau
updated 7 months ago

Comments & Activities

Issue created by @pdureau
Merge request !148Issue #3393417: Bootstrap 5, figure component: default value for figcaption_attributes → (Closed) created by pdureau

Comment 9 months ago →

System Message

pdureau → committed e4dad0c2 on 5.0.x

Issue #3393417 by pdureau: Bootstrap 5, figure component: default value...

Issue was unassigned.
Status changed to Fixed 9 months ago6:54am 12 October 2023
Comment 9 months ago →
🇫🇷France Grimreaper France 🇫🇷
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment 7 months ago →
System Message
Grimreaper → closed merge request !148

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024

Bootstrap 5, figure component: default value for figcaption_attributes

Problem/Motivation

Proposed resolution

Merge Requests

!148Bootstrap 5, figure component: default value for figcaption_attributes Closed

Comments & Activities

!148Bootstrap 5, figure component: default value for figcaption_attributes
Closed