Contrib.social

Fix Drupal ~10.1.0 Input value dialogOptions contains a non-scalar value

Open on Drupal.org →
Created on 11 October 2023, 9 months ago

Problem/Motivation

Not able to add Blocks under Drupal ~10.1.0
with Varbase Layout Builder (VLP) ~9.0.0 or ~10.0.0
Not same as the VLB ~10.1.0 branch, which was managed to work with Drupal ~10.1.0 by default.

Steps to reproduce

Given a Varbase Layout Builder page was created
When chaining the layout of the page
And adding a new block
Then the following AJAx error stops the process
drupal input value "dialogoptions" contains a non-scalar value.

Proposed resolution

  • Change from $this->requestStack->getCurrentRequest()->request->get('dialogOptions') to $this->requestStack->getCurrentRequest()->request->all('dialogOptions')
  • Improve the logic for Varbase Layout Builder Theme Negotiator in the 10.0.x and 9.0.x branches

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-9.0.16, varbase_layout_builder-9.0.37 → , varbase_layout_builder-10.0.37 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3393391 → : Fixed Drupal ~10.1.0 Input value dialogOptions contains a non-scalar value
📌 Task
Status

Fixed

Version

10.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024