- Issue created by @rakshith.thotada
- Status changed to Needs review
over 1 year ago 7:11am 11 October 2023 - last update
over 1 year ago 100 pass - last update
over 1 year ago 100 pass - Issue was unassigned.
- First commit to issue fork.
- Merge request !142Add try/catch to integrity-constraint-violation on update hook 8204 → (Open) created by DresseDk
I have opened an issue fork for for this issue.
I suggest a few changes to the patch by #rakshith.thotada :
1. Place the try/catch block within the foreach loop, as I don't think we want to skip the whole update hook. By placing it inside the foreach loop, we make sure that the update hook still runs through all entries.
2. Instead of catching a generel exception, I suggest we only want to catch the "IntegrityConstraintViolationException".