- Issue created by @rszrama
- πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
vmarchuk β made their first commit to this issueβs fork.
- Merge request !55Issue #3393088: Only update the payment intent if the total price has changed β (Merged) created by Unnamed author
- last update
over 1 year ago 38 pass - Status changed to Needs review
over 1 year ago 12:31pm 11 October 2023 - πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
I've also updated the code to enqueue items only if we really need to update the PaymentIntent.
- πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
Updated MR to compare $order->getTotalPrice() with $order->original->getTotalPrice().
-
rszrama β
committed 074c6d70 on 8.x-1.x authored by
vmarchuk β
Issue #3393088: Only update the payment intent if the total price has...
-
rszrama β
committed 074c6d70 on 8.x-1.x authored by
vmarchuk β
- Status changed to RTBC
about 1 year ago 5:42pm 15 January 2024 - Status changed to Needs work
about 1 year ago 9:16am 16 January 2024 - πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
We still need to fix the failed tests.
- Status changed to Needs review
about 1 year ago 1:24pm 16 January 2024 - πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
@rszrama
Thanks tests I found the problem. There are cases where $total_price and $original_price may not exist, for example, a product has been added to an empty cart (so $original_price doesn't exist) or the last product has been removed from the cart (so $total_price doesn't exist).
See the new method I added getChangedOrderTotalPrice() with comments, it seems to cover all cases.
Link to MR https://git.drupalcode.org/project/commerce_stripe/-/merge_requests/79 -
rszrama β
committed b69170b3 on 8.x-1.x authored by
vmarchuk β
Issue #3393088 by vmarchuk, rszrama: Only update the payment intent if...
-
rszrama β
committed b69170b3 on 8.x-1.x authored by
vmarchuk β
- Status changed to Fixed
about 1 year ago 5:31pm 17 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.