- Issue created by @the_double_a
Adding a patch with the array return type as suggested by the OP
- last update
about 1 year ago 4 pass - Status changed to Needs review
about 1 year ago 11:12am 16 October 2023 - last update
about 1 year ago 4 pass - First commit to issue fork.
- πΊπΈUnited States benjifisher Boston area
I have not tested, but I have reviewed this issue. Either of the patches in #2 or #3 should resolve the problem for PHP 8.1+, and either patch should be compatible with lower versions of PHP as well.
Since the return type is known, I prefer to add a return type rather than an annotation to skip the check.
When implementing an interface in PHP, it is always allowed to specify a more restrictive return type than what the interface says. So a return type of
array
should work with PHP 8.1+ (where the return type ismixed
) and with earlier versions (no return type).I have added a MR based on the patch in #3, and I am hiding the two patches.
- last update
11 months ago 4 pass - First commit to issue fork.
- last update
11 months ago 4 pass - πΊπΈUnited States nicxvan
This looks good, thanks for the review and MR conversion!
- Status changed to Fixed
11 months ago 4:29pm 4 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.