- Issue created by @dydave
- Merge request !89Issue #3392845 by DYdave: Regex: Allow '<title>' tag to be replaced in segment text. β (Merged) created by dydave
- last update
about 1 year ago 6 pass - Status changed to Needs review
about 1 year ago 12:24pm 10 October 2023 - π«π·France dydave
Quick follow-up on this ticket :
Please find attached to this comment a patch on the 2.x branch :
3392845-3-easy_breadcrumb-regex-allow-title-tag-replacement-in-segment-text.patch βWhich is an attempt to provide replacements of the
<title>
tag in the text segments for configured regex underPaths to replace with custom breadcrumbs
.
The added code checks whether the string is present in the text segment and then replaces it once the value of the title has been resolved.This change should be harmless enough and shoudn't have any impact on any of module's current settings.
It should allow adding text around the<title>
in the regex configuration breacrumb replacement segments, instead of strictly only replacing the<title>
tag.Since module's maintainers are now requesting changes to be submitted in merge requests, this patch is also available in issue's merge request opened above at #2.
Lastly, I've related the issue with a few other tickets that I found in current issue queue with similar requests or changes around the same pieces of code.
We would greatly appreciate if you could please try testing the patch, in particular, with various configured parameters, such as titles with HTML Markup, translations,
Paths to be excluded while generating segments
,Titles to be replaced while generating segments
and any other options on module's admin settings form.
Could you please review the changes suggested in the patch and give us your feedback ?Feel free to let us know if you have any questions, comments, suggestions objections or concerns on any aspects of this feature request or this initial patch, we would definitely be very happy to hear your feedback.
Thanks in advance ! - last update
about 1 year ago 6 pass - π«π·France dydave
Wrong file format for previous patch file, uploading the correct one:
3392845-3-easy_breadcrumb-regex-allow-title-tag-replacement-in-segment-text.patch β - Status changed to RTBC
about 1 year ago 11:51am 6 November 2023 I've done some testing, both with what was asked in #3 and some other options. From my tests, this works perfectly, and it's a really useful feature. I think this can be merged. RTBC.
- πΊπΈUnited States Greg Boggs Portland Oregon
Greg Boggs β made their first commit to this issueβs fork.
- last update
9 months ago 6 pass - Status changed to Fixed
9 months ago 9:07pm 17 February 2024 -
Greg Boggs β
committed 9a954c6e on 2.x authored by
DYdave β
Issue #3392845 by DYdave, admirlju: Regex: Allow <title> tag to be...
-
Greg Boggs β
committed 9a954c6e on 2.x authored by
DYdave β
Automatically closed - issue fixed for 2 weeks with no activity.