- Issue created by @yas
- Assigned to xiaohua guan
- @xiaohua-guan opened merge request.
- Status changed to Needs review
about 1 year ago 8:01am 24 October 2023 - π―π΅Japan xiaohua guan Tokyo, Japan
@yas
Please take a look. Thanks.
- Status changed to Needs work
about 1 year ago 10:35pm 24 October 2023 - πΊπΈUnited States yas California πΊπΈ
@xiaohua-guan
Thank you for taking over this issue. Please remove the new blank line at EOF as the following errors:
$ git apply -v /tmp/47.diff Checking patch config/install/rigel.settings.yml... /tmp/47.diff:17: new blank line at EOF. + Checking patch config/schema/rigel.schema.yml... /tmp/47.diff:48: new blank line at EOF. + Applied patch config/install/rigel.settings.yml cleanly. Applied patch config/schema/rigel.schema.yml cleanly. warning: 2 lines add whitespace errors.
Thanks!
- Status changed to Needs review
about 1 year ago 11:58pm 24 October 2023 - π―π΅Japan xiaohua guan Tokyo, Japan
@yas
Thanks for your comment. I've fixed them. Please take a look again. Thanks.
- Status changed to RTBC
about 1 year ago 1:29am 25 October 2023 - πΊπΈUnited States yas California πΊπΈ
@xiaohua-guan
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. -
yas β
committed be86187d on 6.x authored by
Xiaohua Guan β
Issue #3392284 by Xiaohua Guan, yas: Fix the missing schema
-
yas β
committed be86187d on 6.x authored by
Xiaohua Guan β
-
yas β
committed 93af72a2 on 5.x authored by
Xiaohua Guan β
Issue #3392284 by Xiaohua Guan, yas: Fix the missing schema
-
yas β
committed 93af72a2 on 5.x authored by
Xiaohua Guan β
- Status changed to Fixed
about 1 year ago 3:13am 25 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.