Adding item to emtpty queue causes TypeError: array_column()

Created on 6 October 2023, about 1 year ago

Updated 10 October 2023, about 1 year ago

Problem/Motivation

On PHP 8+ when adding an item to an empty queue the following error will be thrown:

TypeError: array_column(): Argument #1 ($array) must be of type array, bool given in array_column() (line 121 of entityqueue/includes/entityqueue.admin.inc).

Steps to reproduce

Running a site using PHP 8, create a new node based queue and try adding an item using its edit form. The error will happen.

Proposed resolution

field_get_items() will return bool false when nothing is in the queue. Since array_column() expects the first value to be an array we must handle the bool false case by defaulting to an empty array instead of always calling array_column().

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom magicmyth

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @magicmyth
@magicmyth opened merge request.
Comment about 1 year ago →
System Message

amateescu → committed 8de033f7 on 7.x-1.x authored by magicmyth →
Issue #3392175 TypeError: array_column(): Argument #1 ($array) must be...
Status changed to Fixed about 1 year ago7:28am 10 October 2023
Comment about 1 year ago →
🇷🇴Romania amateescu
Merged into 7.x-1.x, thanks!
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024