Move TfaLoginContextTrait back to a dedicated Class and add factory.

cmlara → credited dpi → .

cmlara → credited jcnventura → .

Minor property changes to the TfaLoginForm, though that is also slated to be @internal in 2.x see 📌 Mark classes as internal/final/api as applicable Needs work

This needs followups of additional testing of TfaLoginContext as coverage is only 50%

doUserLogin() could probably be moved to TfaLoginTrait, and I'm not sure we really need getUser(), however since they are both present and utilized I'm keeping them in the class for now, we can refactor them out at any time.

Credit for those who worked on #3291024: Move TfaContext to a factory for overridability, and remove constructor from TfaContextInterface → which is the base of this change.

Thanks for the revival, notes for feedback.

lgtm

Thanks @dpi!

Merged to Dev.

Automatically closed - issue fixed for 2 weeks with no activity.