when key is empty, key option configuration save results in null exception and WSOD even after cache rebuild

Shreya_th → made their first commit to this issue’s fork.

Hi @joseph.olstad,
As per my knowledge i have tried to solve this issue .Hope so ,these changes should help prevent null exceptions when the "key" module is not installed and also created MR for this. Kindly review the changes .

Thank you!

Hi @Shreya_th, thanks so much, that looks great, just a minor nit about the indent on the last line change.

Great work thanks again!

Great catch everyone!

I've gone ahead and reviewed the request. Modified it to better handle the conditional and ensure proper handling of null values.

Enjoy!

Hi @wilco,
I have given my valuable time to fix this issue , will you please tell me where is my mistake due to which i didn't receive credit on this issue.

Thank you!

Hi @shreya_th,

If you review the code changes you made, they were only fixing some variable setting conventions but it actually didn't solve the NULL value errors. You can review the following code changes here:

https://git.drupalcode.org/project/language_negotiation_matrix/-/merge_r...

The modifications you made left an error behind here:

$module_handler->moduleExists('key')

As well, if the call \Drupal::service('key.repository')->getKey('language_matrix')->getKeyValues() came back null, it would still WSOD.

Therefore, more conditionals were required. Not to put to fine a point on it, your changes didn't actually solve the fundamental issue.

I thank you for your efforts, but it wasn't enough to fix the issue.

I made an edit error in my comment above, so I corrected it. But just to be clear:

['%enabled' => $module_exists('key')?'Enabled':'Not Installed'])

This in particular $module_exists('key') was the problem. After your fix, this was now throwing errors.

Thanks @Shreya_th and @wilco for your work on this.

Very cool module!