Fatal error when attempting to clone index for multisite

Respect the submission guidelines above! Drupal.org issue forks cause additional work for the project maintainer!

Setup

Solr version: 8.11.2

Drupal Core version: 9.5.11

Search API version: 8.x-1.29

Search API Solr version: 4.3.0

Configured Solr Connector: Standard

Issue

I tried to clone an existing working index for multisite. On save I get "Error: Call to a member function label() on null in Drupal\search_api_solr\Form\IndexSolrMultisiteCloneForm->form() (line 69 of modules/contrib/search_api_solr/src/Form/IndexSolrMultisiteCloneForm.php)."
Inspecting L69 IndexSolrMultisiteCloneForm.php in debugging I see $index get created with label, but then the same line is invoked a second time and $index is not set at all.

Comments & Activities

Issue created by @jonathan_hunt
Comment 11 months ago →
🇳🇿New Zealand jonathan_hunt
Comment 11 months ago →
🇳🇿New Zealand jonathan_hunt
The form is invoked a second time and $form_state->isRebuilding() is true.

Appears to work if I add at L69

if (!isset($index)) { $index = $this->getEntity(); }
This could possibly be added as part of the isRebuilding() == true code path.
First commit to issue fork.
Status changed to Needs review 9 months ago11:03am 14 December 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
31 pass
Comment 9 months ago →
🇮🇳India viren18febS
I have resolved the issue & patch added, please review.