Contrib.social

Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 4 October 2023, about 1 year ago
Updated 4 March 2024, 8 months ago

Problem

Module not ready for Drupal 10.


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
BeautyTips API
Scanned on Jue, 28/09/2023 - 08:04.

9 errors found. 4 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

web/modules/contrib/beautytips/beautytips.install:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 17   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips.module:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 80   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips_manager/beautytips_manager.module:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 71   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 75   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips_ui/beautytips_ui.module:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Ignorar │ 105  │ Call to deprecated function module_load_include().           │
│         │      │ Deprecated in drupal:9.4.0 and is removed from               │
│         │      │ drupal:11.0.0. Use                                           │
│         │      │ Drupal::moduleHandler()->loadInclude($module, $type, $name = │
│         │      │ NULL). Note that including code from uninstalled extensions  │
│         │      │ is no longer supported.                                      │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/includes/drupal_help.inc:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 31   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 41   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 60   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
│ Fix with │ 65   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/includes/textinput.inc:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 57   │ Call to deprecated function drupal_get_path(). Deprecated in │
│ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use          │
│          │      │ Drupal\Core\Extension\ExtensionPathResolver::getPath()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips_manager/src/Form/CustomStylesEditForm.
php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Comproba │ 100  │ The 'beautytips_manager/colorpicker' library is not defined │
│ r        │      │ because the defining extension is not installed. Cannot     │
│ manualme │      │ decide if it is deprecated or not.                          │
│ nte      │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Comproba │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ r        │      │ compatible with the next major version of Drupal core. See │
│ manualme │      │ https://drupal.org/node/3070687.                           │
│ nte      │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips_ui/beautytips_ui.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Comproba │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ r        │      │ compatible with the next major version of Drupal core. See │
│ manualme │      │ https://drupal.org/node/3070687.                           │
│ nte      │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

web/modules/contrib/beautytips/beautytips_manager/beautytips_manager.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Comproba │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
│ r        │      │ compatible with the next major version of Drupal core. See │
│ manualme │      │ https://drupal.org/node/3070687.                           │
│ nte      │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘
📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇪🇸Spain rokkay

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rokkay
  • Merge request !1Issue #3391609: Drupal 10 compatibility fixes → (Open) created by rokkay
  • Comment about 1 year ago →
    🇪🇸Spain rokkay
  • First commit to issue fork.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India sarwan_verma
  • First commit to issue fork.
  • Comment 9 months ago →
    🇮🇳India sumit-k

    Added one commit to resolve error on installation of module.

    Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal10.beautytips_custom_tips' doesn't exist: SELECT * FROM "beautytips_custom_tips"; Array ( ) in beautytips_manager_get_custom_tips() (line 155 of modules/contrib/beautytips/beautytips_manager/beautytips_manager.module).

  • Status changed to Needs work 8 months ago
  • Comment 8 months ago →
    🇺🇸United States seanr

    Still doesn't work because you're missing a composer.json.

  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇺🇸United States seanr

    That works now with the following:

    $ composer require chx/drupal-issue-fork
$ composer drupal-issue-fork https://git.drupalcode.org/issue/beautytips-3391609/-/tree/3391609-drupal-10-compatibility
$ composer require 'drupal/beautytips'
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024