- Issue created by @Panchuk
- Assigned to bobi-mel
- @bobi-mel opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:50pm 2 October 2023 - ๐บ๐ฆUkraine bobi-mel
I added JS behavior to init.js. Please check it.
- Status changed to Needs work
about 1 year ago 5:25am 3 October 2023 - ๐บ๐ฆUkraine abramm Lutsk
That's not the correct way of doing it.
You've wrapped the whole code in Drupal behavior which means it would be called multiple times on the same page and the window load event handler would fire multiple times. Also, why'd you use the window load event listener in behavior?..
Also, there's a comment saying configuration options could be customized but in fact they're hardcoded. - Assigned to Gautam_105@
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:50am 4 October 2023 - ๐บ๐ฆUkraine bobi-mel
@abramm Thanks for mentoring. It's my bad I incorrectly understood the Drupal behavior logic. I fixed the remarks.
@ arthur.baghdasar Please check it. - ๐ฆ๐ฒArmenia arthur.baghdasar
arthur.baghdasar โ made their first commit to this issueโs fork.
-
arthur.baghdasar โ
committed 9beb6d9b on 1.0.x authored by
bobi-mel โ
Issue #3391071: Add JS behavior for init.js
-
arthur.baghdasar โ
committed 9beb6d9b on 1.0.x authored by
bobi-mel โ
- Status changed to Fixed
about 1 year ago 9:28am 4 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.