- Issue created by @pivica
- Status changed to Needs review
about 1 year ago 8:48pm 1 October 2023 - Status changed to Fixed
about 1 year ago 1:13pm 3 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.
The mixin is this one
@mixin heading($font-size) {
margin-top: $headings-margin-top-factor * $font-size;
margin-bottom: $headings-margin-bottom-factor * $font-size;
line-height: $headings-line-height * $font-size;
font-size: $font-size;
}
Two things can be improved here:
1. For the line-height, there is no point of multiplying $headings-line-height with $font-size, browser is already doing this if we just specify `line-height: $headings-line-height`. As additional benefit if we change font size for any reason with additional custom CSS rules there is no need to recalculate line-height, again browser will do that.
2. Introducing a new SASS variable $headings-letter-spacing that is defining heading letter-spacing would be nice. Often this headings have a bit more exotic fonts which require adjusting letter-spacing. Currently we need to do it for all heading rules when needed manually. Adding this in this mixin would simplify this a lot.
Fixed
1.0
BS Base
Automatically closed - issue fixed for 2 weeks with no activity.