When looking into problem of migration configuration entity ( 🐛 Undefined array key "migration" in findMigrationDependencies() Active , found it appears also we should remove createPluginEntityFromPlugin in WordPressMigrationGenerator. There is now a same function in migrate_plus: Migration.php (L 84)
our module does not have -- not sure if matters:
$plugin_definition = $migration_plugin->getPluginDefinition();
changes WordPressMigrationGenerator.php (7 usages found)
127 $migration = static::createEntityFromPlugin('wordpress_authors', $this->authorID);
139 $migration = static::createEntityFromPlugin('wordpress_attachments', $this->attachmentID);
149 $migration = static::createEntityFromPlugin('wordpress_tags', $this->tagsID);
161 $migration = static::createEntityFromPlugin('wordpress_categories', $this->categoriesID);
192 $migration = static::createEntityFromPlugin('wordpress_content', $content_id);
251 $migration = static::createEntityFromPlugin('wordpress_comment', $id);
315 protected static function createEntityFromPlugin($plugin_id, $new_plugin_id) {
- Remove and replace with migrateplus
- If the function createEntityFromPlugin is not available throw an exception
None
None
None
Needs review
3.0
Code
WIP posted. I think it is probably alright. https://git.drupalcode.org/issue/wordpress_migrate-3390755/-/tree/339075...