Contrib.social

Define public image size preset entity methods in interface

Open on Drupal.org →
Created on 29 September 2023, 9 months ago

Problem/Motivation

Currently the ImageSizesPresetEntityInterface interface does not contain any definitions. All public methods of ImageSizesPresetEntity should be defined there instead of the class itself.

Steps to reproduce

  • Check code of ImageSizesPresetEntityInterface - interface is empty
  • Even when checking for ImageSizesPresetEntityInterface via instanceOf, IDEs are not able to autocomplete public entity methods

Proposed resolution

  • Move definitions of public methods to ImageSizesPresetEntityInterface interface

Remaining tasks

  • Create a patch/MR to fix this issue

User interface changes

n/a

API changes

ImageSizesPresetEntityInterface interface can be used as a "contract" for all public ImageSizesPresetEntity methods

Data model changes

n/a

📌 Task
Status

Needs review

Version

3.0

Component

Code

Created by

🇩🇪Germany hctom

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @hctom
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Waiting for branch to pass
  • @hctom opened merge request.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇩🇪Germany hctom

    Please check the MR with the proposed changes. Thanks.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update 9 months ago
    Waiting for branch to pass
  • Comment 9 months ago →
    🇩🇪Germany hctom

    Oops, I just recognized that I commited some of my IDE files accidentally. Those are removed now again.

  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024