- Issue created by @mradcliffe
- @mradcliffe opened merge request.
- Status changed to Needs review
over 1 year ago 2:44pm 27 September 2023 - πΊπΈUnited States mradcliffe USA
I added a merge request with a simple fix, but this may not be the most appropriate resolution, and it does not have any tests.
- πΊπΈUnited States zengenuity
Thanks for the MR. I think this approach sounds reasonable. There's already an indexed array below that code for addresses without name.
My only issue is that I think we should use $mailbox_raw instead of reconstructing the address. In my code, I'm removing the quotes from the name. I'm not totally sure where I got that from. Either Swiftmailer or Symfony Mailer module code probably. I'm not sure it's appropriate. We could probably just get rid of the line creating $mailbox_name and use $mailbox_raw once we validate the address.
- Status changed to Needs work
over 1 year ago 3:36pm 27 September 2023 - πΊπΈUnited States mradcliffe USA
My only issue is that I think we should use $mailbox_raw instead of reconstructing the address. In my code, I'm removing the quotes from the name. I'm not totally sure where I got that from. Either Swiftmailer or Symfony Mailer module code probably. I'm not sure it's appropriate. We could probably just get rid of the line creating $mailbox_name and use $mailbox_raw once we validate the address.
+1. I was thinking this as well, but I wasn't sure about using a variable with the name "raw" in it. :-)
-
zengenuity β
committed 14820d71 on 1.0.x authored by
mradcliffe β
Issue #3390183 by mradcliffe: Using a Name <Email> in Reply-to results...
-
zengenuity β
committed 14820d71 on 1.0.x authored by
mradcliffe β
- Status changed to Fixed
over 1 year ago 8:56pm 30 September 2023 - πΊπΈUnited States zengenuity
I committed the updated version of the code.
Automatically closed - issue fixed for 2 weeks with no activity.