Consolidate methods in jsonapi FileUploadTest

This one is tricky.

The methods assume a clean slate of file uploads (which is fair enough) but break when run one-after-the-other on the same install because they don't get a clean slate.

Another way to handle this would be to split to test in two, but ResourceTestBase contains a lot of setup steps which these methods rely on, in addition to actual test methods, so we would probably need to split the setup steps out into a trait that both ResourceTestBase and the new class can use, maybe that would be OK though.

Trait doesn't help that much because you can't directly override properties between traits and a lot of what we'd want to share is properties. Can probably do a partial trait then redeclare various things in the class but it's not going to be ideal.

Another idea is to do the @requires not_relevant_to_this_test trick for literally every method in the base class for a split, maybe I'll try that to get something going.

Figured it out I think - consolidating the tests that don't actually result in a file upload since those don't need a state reset. And combining two extremely similar test methods where one of them becomes and extra 3-4 lines on the other.

From what I can tell consolidate is good and still covering what was there before.

lauriii → closed merge request !4885

Committed fec7c65 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.