Mark some more tests #slow

Once the worst culprits in 📌 [meta] Refactor ultra-slow tests Active are done, any remaining slower tests tend to stick out towards the end of test runs. We probably want to mark most functional tests with more than 5 methods as #slow. The limit is that we don't wan to mark more tests slow than concurrency * parallel job runs, because that could push one of the very slow tests into the second batch of tests, which would then make the total run slower again.

So if we have 6 parallel functional test runs at concurrency 16 each, the absolute maximum number of @group #slow classes should be 6 * 16 = 96.

Added a few here.

Seems a lot of tests are slow haha. looks good though.

Had some commits locally to push, back to needs review but just more of the same.

https://git.drupalcode.org/project/drupal/-/pipelines/24325 shows the results (combined with several other issues) - 11m1s for a full test run.

If you look at the individual jobs on https://git.drupalcode.org/project/drupal/-/pipelines/24325 and ctrl-F for 'test run duration' you can see all the functional tests are finishing in 5-6 minutes. It is not perfectly balanced and there are still one or two tests that are 'ultra slow' and overshoot all the others, but it's a lot closer than without the MR when they could vary more like 4-8 minutes.

Kernel tests and Functional JavaScript tests are also 'balanced enough'. We can probably do some more work on kernel tests to mark the slow ones there, but could happen in a follow-up.

Kept this open for close to 24 hours in case you found more. But going to remark it now.

Yes I am properly done for now :)

lauriii → closed merge request !4882

Looks like we have 92 functional tests marked as #slow after this so the number of slow tests remain barely under the threshold mentioned in #3.

Committed 4316924 and pushed to 11.x. Thanks!

fwiw with functional test concurrency, the current numbers look like this:

HEAD:

 6*32=192

After 📌 [PP-1] Tweak gitlab CI concurrency, parallelism and test running order for 11 minute test runs Needs review it's lower but still high.

 to 7 * 24=168

So still a lot of headroom to add #slow unless we significantly constrain the number of tests we run at once. Obviously it would be better if we made the actual tests less slow too so they don't need the tag.

Automatically closed - issue fixed for 2 weeks with no activity.