Adding span tag does not dismiss language plug-in error if configuration was saved before adding span

Created on 26 September 2023, 8 months ago
Updated 28 November 2023, 6 months ago

Problem/Motivation

When I add the Language drop-down to the CKEditor, whether it succeeds or not depends on the sequence of steps. I would expect there to be a consistent result once all the requirements are satisfied, regardless of sequence.

Specifically:

  • if I save the configuration
    • after adding the Language drop-down to the toolbar
    • but before adding the span tag to the list of manually editable HTML tags,
  • then a later attempt to add the span tag to the list of manually editable HTML tags does not succeed in dismissing the resulting error message.

The ending requirements are:

  • That Language is part of Active Buttons.
  • That <span> is part of manual tags.

Steps to reproduce

1. Go to https://simplytest.me/
2. In the field Evaluate Drupal Projects, type Drupal
3. Choose Drupal core
4. Accept 10.1.4 (or whatever the latest version offered is) as the default
5. Click Launch sandbox
6. Wait to be redirected to the test instance
7. Enter the admin user name and password
8. Click Configuration, then Text formats and editors
9. On the row for basic HTML, click Configure

10. Drag Language from Available Buttons to Active Toolbar.
11. At the bottom, click Save Configuration.
12. Under CKEditor5 plugin settings, click Source editing
13. Add <span> to the Manually editable HTML tags field
14. At the bottom, click Save Configuration.

Expected result: Return to Text formats and editors; get message The text format Basic HTML has been updated.
Actual result: Error message: The Language plugin needs another plugin to create <span>, for it to be able to create the following attributes: <span lang dir>. Enable a plugin that supports creating this tag. If none exists, you can configure the Source Editing plugin to support it.

10. Drag Language from Available Buttons to Active Toolbar.
11. Under CKEditor5 plugin settings, click Source editing
12. Add <span> to the Manually editable HTML tags field
13. At the bottom, click Save Configuration.

Expected and actual result: Return to Text formats and editors; get message The text format Basic HTML has been updated.

10. Under CKEditor5 plugin settings, click Source editing
11. Add <span> to the Manually editable HTML tags field
12. Drag Language from Available Buttons to Active Toolbar.
13. At the bottom, click Save Configuration.

Expected and actual result: Return to Text formats and editors; get message The text format Basic HTML has been updated.

10. Under CKEditor5 plugin settings, click Source editing
11. Add <span> to the Manually editable HTML tags field
12. At the bottom, click Save Configuration.
13. On the row for basic HTML, click Configure
14. Drag Language from Available Buttons to Active Toolbar.
15. At the bottom, click Save Configuration.

Expected and actual result: Return to Text formats and editors; get message The text format Basic HTML has been updated.

Proposed resolution

Make scenario 1 get the expected final successful result the same as scenarios 2, 3 and 4.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Active

Version

11.0 🔥

Component
CKEditor 5 

Last updated 1 day ago

Created by

🇺🇸United States Charles Belov San Francisco, CA, US

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024