- Issue created by @fallenturtle
- πΊπΈUnited States fallenturtle
Edit: I didn't try adding dashes to the field template before making this issue and that seemed to work:
{{- item.content -}}But I assume we shouldn't need to edit a twig template to get rid of the space.
- πΊπΈUnited States fallenturtle
My previous comment with a solution doesn't seem to be working anymore. Here's what I have working now:
{{- item.content|render|replace({"\n":''})|raw -}} - π¨π¦Canada mandclu
There's work being done on the formatting being generated by the recurring formatter in β¨ Improve recurring theming: Show the end time and don't show the day during daily reoccurences Fixed , and this extra space was raised in comment #3 of that issue. I'm tempted to close this issue as duplicate, but I'm not sure if any of the proposed changes there will fix the problem. If you have an idea on the best way to fix it in the formatter code I'd be happy to work that in.
- π¨π¦Canada mandclu
The most recent commit to the MR in β¨ Improve recurring theming: Show the end time and don't show the day during daily reoccurences Fixed should address the space. Please test and provide feedback there.
- Status changed to Closed: duplicate
over 1 year ago 6:26am 2 December 2023 - Status changed to Active
over 1 year ago 11:35am 6 December 2023 On further inspection, I believe this issue is still present, and affects the original Smart Date Formatter (
smartdate_default
) plugin, whereas the work done in β¨ Improve recurring theming: Show the end time and don't show the day during daily reoccurences Fixed only addressed when the Recurring (smartdate_recurring
) plugin was used.I believe we'll likely need to introduce a new theme template which ensures that the line break spacing otherwise added by the normal time theme rendering is automatically stipped before adding the join render elements.
Attached a patch which introduces a custom smart_date theme suggestion for the
time
, which will ensure that the output is still rendered inline (without a line break).The one issue is that if the site decides to enable twig template debugging, then it'll "break" again, but that's outside the scope of this ticket.
- Merge request !72Issue #3389649: Smart Date Formatter: Can't get rid of space between Date and Date/time join character β (Open) created by codebymikey
- Status changed to Needs review
over 1 year ago 2:56pm 6 December 2023 Will need to cherrypicked onto 4.1.x if happy with the implementation.
- π¨π¦Canada mandclu
OK please update the changes to target the 4.1.x branch.