Fix the heat_template_version error in OpenStack stack template data

Issue created by @Xiaohua Guan
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
@xiaohua-guan opened merge request.
Status changed to Needs review 10 months ago1:21am 22 September 2023
Comment 10 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
Comment 10 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Status changed to Needs work 10 months ago2:56am 22 September 2023
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the fix. Can you add the BDD test case in OpenStack-ATDD-03-16-OperateStacks.feature for the test scenario w/ and w/o the single quotes? Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Status changed to Needs review 10 months ago6:11am 22 September 2023
Comment 10 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
@yas

I've added test cases. Please take a look. Thanks.
Status changed to Needs work 10 months ago8:15am 22 September 2023
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for adding the test scenario. I posted my minor comment. Thanks!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Status changed to Needs review 10 months ago10:19am 22 September 2023
Comment 10 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
@yas

Thanks for your comment. I've fixed it. Please take a look again. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
30:43
27:19
Running
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
Status changed to RTBC 9 months ago8:34am 27 September 2023
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the fix. I ran the BDD testing and the tests have been passed successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Status changed to Needs work 9 months ago8:35am 27 September 2023
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Can you please rebase the patch? Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Status changed to Needs review 9 months ago11:00am 27 September 2023
Comment 9 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
Status changed to RTBC 9 months ago11:18am 27 September 2023
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Comment 9 months ago →
System Message

yas → committed 2dd88f44 on 6.x authored by Xiaohua Guan →
Issue #3388999 by Xiaohua Guan, yas: Fix the heat_template_version error...
Comment 9 months ago →
System Message

yas → committed d6d6eb16 on 5.x authored by Xiaohua Guan →
Issue #3388999 by Xiaohua Guan, yas: Fix the heat_template_version error...
Status changed to Fixed 9 months ago11:26am 27 September 2023
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
@xiaohua-guan opened merge request.
Status changed to Needs review 9 months ago11:48am 28 September 2023
Comment 9 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Status changed to Needs work 9 months ago4:21am 29 September 2023

🇺🇸United States yas California 🇺🇸

@xiaohua-guan

I ran the BDD tests but unfortunately, it didn't passed succssfully:

    Examples:
      | stack_name_operate                | heat_template_version  |
      | BDD_stack_0f52ca0_operate         | &#039;2013-05-23&#039; |
        Failed step: And I should see the success message "has been previewed"
        The page 'http://localhost/clouds/openstack/bdd_0f52ca0_regionone/stack' does not contain any success messages (Behat\Mink\Exception\ExpectationException)
        │
        │  Screenshot at: sites/screenshots/092823-185939_OpenStack-ATDD-03-16-OperateStacks_55F.png
        │
        └─ @AfterStep # Drupal\DrupalExtension\Context\DrupalContext::takeScreenshotOnFailure()
      | BDD_stack_0f52ca0_another_operate | 2013-05-23             |

Can you check it?

Thanks

Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Status changed to Needs review 9 months ago9:50am 30 September 2023
Comment 9 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
Status changed to Needs work 9 months ago3:36pm 30 September 2023
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. Can you please rebase the patch? Thanks
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

I posted my comments. I think we can try to use |raw for the single quote (') escape. Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Status changed to Needs review 9 months ago1:14am 1 October 2023
Comment 9 months ago →
🇯🇵Japan Xiaohua Guan Tokyo, Japan
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the hotfix. I ran the BDD tests and the tests have been passed succssfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
367 pass
Comment 9 months ago →
System Message

yas → committed 366f2cf2 on 6.x authored by Xiaohua Guan →
Issue #3388999 by Xiaohua Guan, yas: Hotfix - Fix the...
Comment 9 months ago →
System Message

yas → committed 8e1cb399 on 5.x authored by Xiaohua Guan →
Issue #3388999 by Xiaohua Guan, yas: Hotfix - Fix the...
Status changed to Fixed 9 months ago7:34am 1 October 2023
Comment 9 months ago →
🇺🇸United States yas California 🇺🇸
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the heat_template_version error in OpenStack stack template data

Problem/Motivation

Comments & Activities