- Issue created by @longwave
- last update
about 1 year ago 30,168 pass - @longwave opened merge request.
- Status changed to Needs work
about 1 year ago 11:02pm 20 September 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Not sure what I am doing wrong here. I think I have followed the docs in https://docs.gitlab.com/ee/ci/pipelines/downstream_pipelines.html?tab=Pa... but the child pipeline immediately fails with "This job could not start because it could not retrieve the needed artifacts."
- last update
about 1 year ago 30,379 pass - ๐ฌ๐งUnited Kingdom longwave UK
Seems to be working! The error I made previously was that the default
variables
is overwritten by the job-specificvariables
.This still needs work to tidy up the variables and also the use of the caches, some of which is redundant now.
- ๐ฌ๐งUnited Kingdom catch
I just opened ๐ Move lint jobs to the pipeline Active (moving everything to the child pipeline) which would conflict with this. The goal is very similar so we should go ahead here and then the other issue will have a better baseline to deal with.
- last update
about 1 year ago 30,379 pass - last update
about 1 year ago 30,379 pass - Status changed to Needs review
about 1 year ago 1:32pm 4 October 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Cleaned up the use of
cache
- we only need this in the build steps, after this we are passing around artifacts instead and so the lint and test jobs don't need caches.Also moved
stage
in the child pipeline to the defaults, given that we only have one stage now. 13:17 39:11 Running- last update
about 1 year ago 30,379 pass - ๐ฌ๐งUnited Kingdom longwave UK
Also ensured that build (and lint) run on scheduled pipelines, because the test jobs now need the parent build job artifacts.
- ๐ฌ๐งUnited Kingdom catch
This covers 90% of what I wanted to get from ๐ Move lint jobs to the pipeline Active and the last 10% is quite marginal, so closed as duplicate.
MR looks great to me.
- Status changed to Needs work
about 1 year ago 3:27pm 4 October 2023 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- last update
about 1 year ago 30,379 pass - Status changed to Needs review
about 1 year ago 3:59pm 4 October 2023 - Status changed to RTBC
about 1 year ago 8:24pm 4 October 2023 - ๐ฌ๐งUnited Kingdom catch
This is excellent and low risk. Will commit in ~24 hours if no objections, or sooner if there's a +1.
- ๐ช๐ธSpain fjgarlin
+1 from my side for what is worth.
I love the ability of referencing parent pipelines jobs in the โneedsโ section. I think itโsa great refactoring.
-
lauriii โ
committed 4a70e448 on 11.x
Issue #3388693 by longwave, catch, fjgarlin: Use composer and yarn...
-
lauriii โ
committed 4a70e448 on 11.x
- Status changed to Fixed
about 1 year ago 6:53am 5 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.