- Issue created by @agentrickard
- First commit to issue fork.
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - πΊπΈUnited States ddavisboxleitner
A .gitlab-ci.yml file has been created for the project following the template provided in the referenced article.
https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/gitlab-...
- last update
about 1 year ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - Status changed to Needs work
12 months ago 3:50pm 27 November 2023 - πΊπΈUnited States agentrickard Georgia (US)
@ddavisboxleitner
So this is missing the local DNS registration that we need for tests.
This is what we use for DrupalCI. See drupalci.yml and define_subdomains.sh
#!/bin/bash declare -a HOSTS=(${CONTAINER_NAME} 'example.com') declare -a SUBDOMAINS=('one' 'two' 'three' 'four' 'five' 'six' 'seven' 'eight' 'nine' 'ten') for HOST in ${HOSTS[@]}; do echo '127.0.0.1' ${HOST} >> /etc/hosts for SUBDOMAIN in ${SUBDOMAINS[@]}; do echo '127.0.0.1' ${SUBDOMAIN}.${HOST} >> /etc/hosts echo '127.0.0.1' ${SUBDOMAIN}.example.${HOST} >> /etc/hosts done done
- last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - last update
12 months ago 93 pass - πΊπΈUnited States ddavisboxleitner
We currently have 4 phpunit errors:
There were 4 errors: 1) Drupal\Tests\domain_alias\Functional\DomainAliasActionsTest::testDomainActions Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected. /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:794 /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:130 /builds/issue/domain-3388682/domain_alias/tests/src/Functional/DomainAliasActionsTest.php:59 /builds/issue/domain-3388682/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 2) Drupal\Tests\domain_alias\Functional\DomainAliasEnvironmentTest::testDomainAliasEnvironments Behat\Mink\Exception\ExpectationException: The string "four.example.com" was not found anywhere in the HTML response of the current page. /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:794 /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:324 /builds/issue/domain-3388682/web/core/tests/Drupal/Tests/WebAssert.php:540 /builds/issue/domain-3388682/web/core/tests/Drupal/Tests/WebAssert.php:528 /builds/issue/domain-3388682/domain_alias/tests/src/Functional/DomainAliasEnvironmentTest.php:93 /builds/issue/domain-3388682/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 3) Drupal\Tests\domain_alias\Functional\DomainAliasListHostnameTest::testDomainAliasEnvironments Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected. /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:794 /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:130 /builds/issue/domain-3388682/domain_alias/tests/src/Functional/DomainAliasListHostnameTest.php:70 /builds/issue/domain-3388682/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 4) Drupal\Tests\domain_alias\Functional\DomainAliasWildcardTest::testDomainAliasWildcards Behat\Mink\Exception\ExpectationException: The string "four.example.com" was not found anywhere in the HTML response of the current page. /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:794 /builds/issue/domain-3388682/vendor/behat/mink/src/WebAssert.php:324 /builds/issue/domain-3388682/web/core/tests/Drupal/Tests/WebAssert.php:540 /builds/issue/domain-3388682/web/core/tests/Drupal/Tests/WebAssert.php:528 /builds/issue/domain-3388682/domain_alias/tests/src/Functional/DomainAliasWildcardTest.php:82 /builds/issue/domain-3388682/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 ERRORS! Tests: 93, Assertions: 3231, Errors: 4.
It is possible the tests themselves need a fix.
- last update
11 months ago 93 pass - πΊπΈUnited States agentrickard Georgia (US)
These tests all pass for me locally.
- last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - πΊπΈUnited States ddavisboxleitner
The current issue seems to be that we cannot get the SIMPLETEST_BASE_URL value set properly before the phpunit tests are run. The subdomain registration section of the tests are failing.
- last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass - πΊπΈUnited States agentrickard Georgia (US)
The primary issue turns out to be the fact that tests run in a subdirectory by default (that was not the case on Jenkins). A few minor test changes fixes most of that. Given that installing Drupal in a subdirectory is possible, fixing the tests seems prudent.
- last update
11 months ago 90 pass, 6 fail - last update
11 months ago 93 pass - last update
11 months ago 93 pass - last update
11 months ago 93 pass -
agentrickard β
committed 45b5c3c1 on 2.0.x authored by
ddavisboxleitner β
Issue #3388682 by ddavisboxleitner, agentrickard: Move automated testing...
-
agentrickard β
committed 45b5c3c1 on 2.0.x authored by
ddavisboxleitner β
- Status changed to Fixed
11 months ago 8:51pm 28 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.