update report data permission not working

I have made a merge request with the change that will hopefully fix this issue. This is also a patch with the same changes for those who might want to use the fix before it gets merged.

I have updated the patch and merge request as I noticed that even if you had the permission 'update report data' you could not update the report data as it was looking for a different permission.

Looks pretty good to me. I would say it'd probably be preferable to inject → the AccountProxy service rather than using Drupal::currentUser but can see the module was previously using that method to get the user. The class is well set up for dependency injection so I think it might be worth doing that.

That's the only thing I would suggest, otherwise looks good.

I'll put this in "Needs work" for now - if you feel like using dependency injection for the current user/accountproxy service then please do otherwise perhaps someone else can take a look and move it to RTBC?

Thanks for the suggestion Welly. I have updated the patch and the merge request, let me know if everything you have any other suggestions.