- Issue created by @javi-er
- ๐ฎ๐ณIndia shiv_yadav
Hi javi-er ,
As your request Numbered settings "none" renders as an OL instead of UL. I have fixed it.
Attached patch please review it. - Status changed to Needs review
over 1 year ago 1:45pm 21 September 2023 @shiv_yadav the problem with your patch is that it will still create a
<ul class="none">
, the solution is actually checking thatbelow_type
is different than"none"
.- Merge request !7Issue #3388382: Numbered settings "none" renders as an OL instead of UL โ (Open) created by javi-er
- Status changed to Needs work
over 1 year ago 8:19pm 3 October 2023 - Status changed to Needs review
over 1 year ago 8:21pm 3 October 2023 - ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
liam morland โ made their first commit to this issueโs fork.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
The conditional for the end tag needs to match the change for the start tag. I have done this.
This raises a larger issue. With this change,
none
gives aul
whiledisc
gives aol
but with the bullets making it look the same asul
. I'm not sure this makes sense. Perhapsdisc
and the other non-number options should give aul
. Or perhaps it should always beol
because it is a list of content headers in the order that they appear.