Contrib.social

Numbered settings "none" renders as an OL instead of UL

Open on Drupal.org →
Created on 19 September 2023, 9 months ago
Updated 3 October 2023, 9 months ago

Problem/Motivation

When editing a table of content type, if you choose "none" under "Numbering Type" it will render as <ol class="none"> instead of <ul>.

Steps to reproduce

Edit a table of content type settings and choose "none" for "Numbering Type".

Proposed resolution

On toc-tree.html.twig at line 40 change {% if item.below_type %} with {% if item.below_type != "none" %}

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

javi-er

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @javi-er
  • Comment 9 months ago →
    🇮🇳India shiv_yadav

    Hi javi-er ,
    As your request Numbered settings "none" renders as an OL instead of UL. I have fixed it.
    Attached patch please review it.

  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇮🇳India shiv_yadav
  • Comment 9 months ago →
    javi-er

    @shiv_yadav the problem with your patch is that it will still create a <ul class="none">, the solution is actually checking that below_type is different than "none".

  • Status changed to Needs work 9 months ago
  • @javi-er opened merge request.
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    javi-er

    I opened a merge request with this change, please review it.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024