- Issue created by @_tarik_
- Merge request !21Issue #3388339: Provide a way to use different values for the target attribute for the title if the Link checkbox is enabled β (Merged) created by _tarik_
- last update
over 1 year ago 30 pass - Status changed to Needs review
over 1 year ago 8:48am 20 September 2023 - π§πͺBelgium swentel
Makes much sense. The states value is hard coded though to node_title which shouldn't as the field is also used for user, taxonomy, media fields, so we need to figure out something else here. Removing the #states in the patch is fine for me as well, we could always add a description explaining that the target only works when the link checkbox is enabled.
- Status changed to Needs work
over 1 year ago 2:25pm 27 December 2023 - Status changed to Needs review
over 1 year ago 9:45pm 28 December 2023 - πΊπ¦Ukraine _tarik_ Lutsk
Hi swentel
Thanks for the code review.I have debugged the code and found that we can use the plugin_settings_edit option from the form state storage as it contains the current field name.
See Drupal\field_ui\Form\EntityDisplayFormBase::multistepSubmit().Also, I fixed the hardcoded field name in states on line 31 in the Title.php
-
swentel β
committed da07d0be on 8.x-3.x authored by
_tarik_ β
Issue #3388339: Provide a way to use different values for the target...
-
swentel β
committed da07d0be on 8.x-3.x authored by
_tarik_ β
- Status changed to Fixed
over 1 year ago 12:00pm 29 December 2023 - π§πͺBelgium swentel
yes, awesome, merged, will come in release somewhere next week, thanks!
- Status changed to Fixed
over 1 year ago 12:01pm 29 December 2023