- Issue created by @zarexogre
- 🇩🇪Germany jurgenhaas Gottmadingen
Would you mind starting an issue fork an open a merge request with the proposed changes?
- 🇨🇦Canada danrod Ottawa
I added a patch for this, needed this module for a project, screenshot attached.
- Status changed to Needs review
over 1 year ago 7:52pm 19 September 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Thanks @danrod. Did you know that patches are going away soon? Issue forks with merge requests are so much more convenient for everyone and cause less work for all of us.
- 🇨🇦Canada danrod Ottawa
@jurgenhaas I tried creating a merge request for it, but I don't have push access, I can't push my changes.
- 🇩🇪Germany jurgenhaas Gottmadingen
Does it look like this above?
And then you should check these:
- What is the remove URL of the repository to which you want to push? Find out with
git remote -v
- Have you uploaded your SSH key to Drupal's GitLab?
- What is the remove URL of the repository to which you want to push? Find out with
- @danrod opened merge request.
- Status changed to Needs work
over 1 year ago 3:39pm 21 September 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Thanks @danrod, glad it worked out with the MR. I've left a comment and a code suggestion there.
- Status changed to Needs review
over 1 year ago 5:40pm 21 September 2023 - 🇨🇦Canada danrod Ottawa
Thanks @jurgenhaas, done, please review, thanks for the suggestion.
-
jurgenhaas →
committed f1c9f24f on 4.1.x authored by
danrod →
Issue #3388231 by danrod, jurgenhaas, zarexogre: TypeError: Drupal\drd\...
-
jurgenhaas →
committed f1c9f24f on 4.1.x authored by
danrod →
- Status changed to Fixed
about 1 year ago 11:24am 22 September 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
This looks great, nice and simple. Thanks a lot @danrod for going through this.
Automatically closed - issue fixed for 2 weeks with no activity.