- Issue created by @heikkiy
- Assigned to shiv_yadav
- Issue was unassigned.
- 🇮🇳India abhiyanshu
@HeikkiY ,
I scanned the project with Upgrade status and noticed the same problems reported by you
and i have fixed those reported problems and created the patch for it ,Please refer to the attached patch file, Thanks.
- Status changed to Needs review
about 1 year ago 1:16pm 19 September 2023 - 🇫🇮Finland heikkiy Oulu
I tested applying the patch against 4.0.7 but it failed.
Interesting is that I cannot seem to ind 4.x dev branch from Composer to test applying against it. Composer reports only following versions to be available:
* 4.0.7, 4.0.6, 4.0.5, 4.0.4, 4.0.3, 4.0.2, 4.0.1, 4.0.0, 3.x-dev, 3.4.0, 3.3.0, 3.2.0, 3.1.0, 3.0.0-rc2, 3.0.0-rc1, 2.2.0, 2.1.0, 2.0.0, dev-3.x
I crI ended up creating a new fork and applying your patch.
After applying the fork with Composer I get the following fatal error:
PHP Fatal error: Class Drupal\adv_varnish\Form\CacheBlockForm contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Drupal\Core\Form\FormInterface::getFormId, Drupal\Core\Form\FormInterface::buildForm) in /var/www/html/web/modules/contrib/adv_varnish/src/Form/CacheBlockForm.php on line 21.There was also a third warning with Upgrade status:
The 'adv_varnish/adv_varnish_user_data' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.I think that one can be ignored though,
If possible I would recommend continuing the work in https://git.drupalcode.org/issue/adv_varnish-3388213/-/tree/3388213-drup... if you have push access.
- Status changed to Needs work
about 1 year ago 5:11am 20 September 2023 - First commit to issue fork.
- Assigned to shumer
- Merge request !14Issue #3388213 by shumer: Drupal 10 compatibility issues → (Merged) created by shumer
- Status changed to Fixed
12 months ago 1:26pm 29 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.