Avoid static \Drupal calls inside class methods and use proper DI

sandipta → closed merge request !16

sandipta → reopened merge request !16

sandipta → closed merge request !16

I can help with reviewing this issue.

Hi Sandipta,

can we please discuss the scope of this issue? I think the title suggests changes that are too broad and it will make the review hard. Maybe we can restrict ourselves to plugins first.

I see that you started to introduce changes in the merge request. But there are many other plugins that also make static calls to the container.

From static analysis I can see:

• GoogleAnalyticsCounterResultProcessorPluginBase fixed in MR (see comments)
• /Plugin/GoogleAnalyticsCounterResultProcessor/DefaultResultProcessor
• /Plugin/GoogleAnalyticsCounterResultProcessor/DefaultResultProcessor
• /Plugin/GoogleAnalyticsCounterResultProcessor/UrlAliasResultProcessor
• /Plugin/QueueWorker/GoogleAnalyticsCounterQueueBase

It is a little bit unusual that the plugin base is not in the Plugin/ namespace.

Also, I think it is best practice to make your changes in the issue branch (in this case 3388151-avoid-static-drupal) rather than directly in the fork. And then make a merge request from the issue branch to the actual repository. But maybe it doesn't matter.

Sure , will keep that in mind @simonbaese.

@sandipta What is the status on this issue? Do you need help to progress?

Checked everything,two files remain where DI hasn't been implemented yet:

1. src/Plugin/GoogleAnalyticsCounterResultProcessor/UrlAliasResultProcessor.php
2. src/GoogleAnalyticsCounterHelper.php

I'll begin working on them soon.
@simonbaese

I have updated the MR, added DI in the remaining files. Please review.

MR rebased for conflict resolution.