- Issue created by @esolano
- Status changed to Needs review
9 months ago 12:40am 19 September 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
9 months ago Waiting for branch to pass - 🇺🇸United States lemming
Hi @esolano thanks for finding and patching this issue.
Took me a little bit to remember why this looked so familiar. This was a changed to attempt to appease drupal-check / PHPStan analysis tools.
50 Access to an undefined property
Drupal\Core\Field\FieldItemListInterface::$alias.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-propertyWhich in this case is harmless but I wanted to avoid ignoring or having too many of those pile up (makes it harder to wade through actual problems). I was hoping that maybe D10 w/ PHP8 would start using the which would resolve this, but I don't think they are making that change.
#[\AllowDynamicProperties]Any of the fixes that make drupal-check happy really complicate the code and hurts readability, so we should tell the analysis tool to ignore it for now. Could you adjust your patch to add the PHPStan ignore before both of those lines:
/* @phpstan-ignore-next-line */ - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
9 months ago Waiting for branch to pass - 🇨🇷Costa Rica esolano
Hi @lemming thanks for the explanation and reviewing the patch. Here's the change you requested.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
9 months ago Waiting for branch to pass - Status changed to Fixed
9 months ago 10:09pm 24 September 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
9 months ago Waiting for branch to pass - @lemming opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
9 months ago Waiting for branch to pass Automatically closed - issue fixed for 2 weeks with no activity.