Contrib.social

Freeze the use of wiled card over Blazy and Slick modules, at blazy-2.16.0, slick-2.9.0, and slick_views-2.7.0

Open on Drupal.org →
Created on 18 September 2023, over 1 year ago
Updated 15 October 2023, about 1 year ago

Problem/Motivation

Blazy, Slick, Slick Views issues after the major finalization work for 3.x
But that was committed to the 2.x branch too

Blazy 8.x-2.17 was release on: 18 Sep 2023 by: gausarts
https://www.drupal.org/project/blazy/releases/8.x-2.17 →

2.17 is a major finalization work for 3.x and has breaking changes

Slick 8.x-2.10 was release on: 18 Sep 2023 by: gausarts
https://www.drupal.org/project/slick/releases/8.x-2.10 →

2.10 is a major finalization work for 3.x and has breaking changes

Slick Views 8.x-2.8 was release on: 18 Sep 2023 by: gausarts
https://www.drupal.org/project/slick_views/releases/8.x-2.8 →

2.8 is a major finalization work for 3.x and has breaking changes

------
On updates: Important to double check and test Slick Sliders, and Slick Carousals, and lazy loading
They had fixes with the IO. ( Intersection Observer API )

Message Error: Call to a member function getValue() on null in varbase_media_preprocess_field()

Steps to reproduce

After update Blazy and slick this issue appear

Error: Call to a member function getValue() on null in varbase_media_preprocess_field() (line 135 of /app/docroot/modules/contrib/varbase_media/varbase_media.module)
#0 [internal function]: varbase_media_preprocess_field(Array, 'field', Array)
#1 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(287): call_user_func_array('varbase_media_p...', Array)
#2 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('field', Array)
#3 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#4 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#5 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#6 /app/docroot/sites/default/files/php/twig/65084234c3bad_media--image.html.twig_XfgPri0FxrJxpYbrG9c_lqh9u/Jrx0Zn_koMUOjBPd4wEu7TIxZO0SwZMqrDTU6ZJShhg.php(50): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#7 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_7ca2456b2e2609f2af333b1dae6de8c0->doDisplay(Array, Array)
#8 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#9 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#10 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#11 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('themes/custom/u...', Array)
#12 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('media', Array)
#13 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#14 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#15 /app/docroot/sites/default/files/php/twig/65084234c3bad_ds-field-minimal.html.twi_EkTSNSPrOHGfC2fB5TS1XbdnG/uOfJBLqbyuTacelhBKQs-jg6by-7fHQ5kJ1jeFqeyMM.php(71): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#16 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_5ac8f82864b2be17e04158e28127247c->doDisplay(Array, Array)
#17 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#18 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#19 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#20 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
#21 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('field', Array)
#22 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#23 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#24 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#25 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#26 /app/docroot/sites/default/files/php/twig/65084234c3bad_bs-1col.html.twig_rdubshD0Z_abbXyV9Rg8TSdcd/uja_tmYkGR87jtxUFktvqvKX2LTe4J6g4Y7epVMpjuE.php(57): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#27 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_48c008e671a57e4fd4d94da9de3547f2->doDisplay(Array, Array)
#28 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#29 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#30 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#31 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
#32 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('bs_1col', Array)
#33 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#34 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#35 /app/docroot/sites/default/files/php/twig/65084234c3bad_ds-entity-view.html.twig_8CxMl4mjGsu1NWQjfnDbxg19U/bgf8oaRtYLx-hgZi2XFw2Cjvjl5jQUmxgr3vTDASzQk.php(42): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#36 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_22bd7f68dbece7031d41bf4573f307ed->doDisplay(Array, Array)
#37 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#38 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#39 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#40 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
#41 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('ds_entity_view', Array)
#42 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#43 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#44 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#45 /app/docroot/sites/default/files/php/twig/65084234c3bad_slick-vanilla.html.twig_XVUIhAt6kbuGg9lNQGNqmtJGe/Ws5Ltqx6f2HuWZiMS_LKGlZqQwzEszsdi0Laq41u-1E.php(63): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#46 /app/vendor/twig/twig/src/Template.php(182): __TwigTemplate_8a0c2842c8e2267723c17925f95999f5->block_slick_vanilla(Array, Array)
#47 /app/docroot/sites/default/files/php/twig/65084234c3bad_slick-vanilla.html.twig_XVUIhAt6kbuGg9lNQGNqmtJGe/Ws5Ltqx6f2HuWZiMS_LKGlZqQwzEszsdi0Laq41u-1E.php(46): Twig\Template->displayBlock('slick_vanilla', Array, Array)
#48 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_8a0c2842c8e2267723c17925f95999f5->doDisplay(Array, Array)
#49 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#50 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#51 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#52 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
#53 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('slick_vanilla', Array)
#54 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#55 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#56 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#57 /app/docroot/sites/default/files/php/twig/65084234c3bad_slick.html.twig_XHPZBN_PKC99NVE3NOCUugcMT/0ksRmuhJ7AR042DV9XOtU6wQKd4_-MycsHcYmPgHUQI.php(116): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#58 /app/vendor/twig/twig/src/Template.php(182): __TwigTemplate_885b70d3bfe8d3a0f846c0af65181ac0->block_slick_content(Array, Array)
#59 /app/docroot/sites/default/files/php/twig/65084234c3bad_slick.html.twig_XHPZBN_PKC99NVE3NOCUugcMT/0ksRmuhJ7AR042DV9XOtU6wQKd4_-MycsHcYmPgHUQI.php(87): Twig\Template->displayBlock('slick_content', Array, Array)
#60 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_885b70d3bfe8d3a0f846c0af65181ac0->doDisplay(Array, Array)
#61 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#62 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#63 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#64 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('themes/custom/u...', Array)
#65 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('slick', Array)
#66 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#67 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#68 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#69 /app/docroot/sites/default/files/php/twig/65084234c3bad_slick-wrapper.html.twig_PBStcCC7YPcodFkvvaMHDQpN5/3sIORStadL689ytLXeePWVYBjWSgFDn7F5fX4H3Ccyw.php(64): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#70 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_8dfe90a07bb0503e807382d680803185->doDisplay(Array, Array)
#71 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#72 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#73 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#74 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
#75 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('slick_wrapper', Array)
#76 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
#77 /app/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
#78 /app/docroot/sites/default/files/php/twig/65084234c3bad_views-view--sectoral-issu_y9OAzGQFPAdZ8Jq_yDTIW5bLX/h2XpX9KrekJ0A0Bypw-e0tzNdboIfNKMYh23qSooxFI.php(122): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#79 /app/vendor/twig/twig/src/Template.php(405): __TwigTemplate_23ebee153808f354c01e08b02b3d31a5->doDisplay(Array, Array)
#80 /app/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
#81 /app/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
#82 /app/docroot/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
#83 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('themes/custom/u...', Array)
#84 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('views_view__sec...', Array)
#85 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#86 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
#87 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, true)
#88 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(160): Drupal\Core\Render\Renderer->render(Array, true)
#89 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#90 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(161): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#91 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(175): Drupal\Core\Render\Renderer->renderPlain(Array)
#92 /app/docroot/core/modules/big_pipe/src/Render/BigPipe.php(693): Drupal\Core\Render\Renderer->renderPlaceholder('callback=Drupal...', Array)
#93 /app/docroot/core/modules/big_pipe/src/Render/BigPipe.php(547): Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=Drupal...', Array)
#94 /app/docroot/core/modules/big_pipe/src/Render/BigPipe.php(305): Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object(Drupal\Core\Asset\AttachedAssets))
#95 /app/docroot/core/modules/big_pipe/src/Render/BigPipeResponse.php(112): Drupal\big_pipe\Render\BigPipe->sendContent(Object(Drupal\big_pipe\Render\BigPipeResponse))
#96 /app/vendor/symfony/http-foundation/Response.php(381): Drupal\big_pipe\Render\BigPipeResponse->sendContent()
#97 /app/docroot/index.php(20): Symfony\Component\HttpFoundation\Response->send()
#98 {main}

Proposed resolution

  • Support old base code to keep the logic working when developers update Varbase Media, But did not update Blazy or Slick yet.

Moving with freezing the use of wiled card over Blazy and Slick modules, by using a static version for them.

    "drupal/blazy": "2.16.0",
    "drupal/slick": "2.9.0",
    "drupal/slick_views": "2.7.0"

They are doing a major finalization work for 3.x and has breaking changes.
Not happy with their releasing strategy.
They should keep the code of the 3.x branch in 3.x
But they are getting major changes in the 2.x branch.

Packagers and assemblers can switch to use the ~3.0 version when they like.

Planed to remove Blazy, Slick, and Slick Views from Varbase ~10

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-10.0.0-beta2 → , varbase_media-10.0.0-beta2, varbase-9.0.16 → , varbase_media-9.0.25 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3388011 → by Rahaf Albawab → : Freezed the use of wiled card over Blazy and Slick modules, at blazy-2.16.0, slick-2.9.0, and slick_views-2.7.0
🐛 Bug report
Status

Fixed

Version

9.0

Component

Code

Created by

🇯🇴Jordan rahaf albawab Amman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024