Config-import does not change theme to dark mode as value is set in localStorage

@njlim something is strange with this MR, I can't push a change.

Can you cherry-pick your change to the correct branch 3387653-config-import-does-not and open a new MR there?

diff --git a/js/init.js b/js/init.js
index 390c9cee..860de79c 100644
--- a/js/init.js
+++ b/js/init.js
@@ -32,13 +32,12 @@ function ginInitDarkmode() {
 
 ginInitDarkmode();
 
-// GinDarkMode is not set yet.
+// GinDarkMode is not set yet or config changes detected.
 window.addEventListener('DOMContentLoaded', () => {
-  if (!localStorage.getItem('Drupal.gin.darkmode')) {
-    localStorage.setItem('Drupal.gin.darkmode', drupalSettings.gin.darkmode);
-    ginInitDarkmode();
-  }
-  else if (drupalSettings.gin.darkmode != localStorage.getItem('Drupal.gin.darkmode') && !drupalSettings.gin.show_user_theme_settings) {
+  if (
+    !localStorage.getItem('Drupal.gin.darkmode') ||
+    (drupalSettings.gin.darkmode != localStorage.getItem('Drupal.gin.darkmode') && !drupalSettings.gin.show_user_theme_settings)
+  ) {
     localStorage.setItem('Drupal.gin.darkmode', drupalSettings.gin.darkmode);
     ginInitDarkmode();
   }

And apply this diff.

Thank you!

Closing because of the lack of activity. Feel free to reopen if we still need to work on this.

I'm seeing the same issue and I'm happy to test and provide feedback. Just wondering: do I need the changes from the MR and the changes from #4? If so, I'm happy to prepare that in an MR so that we can follow-up from there.

I figured it out, I adjusted the MR with the changes from #4 and can confirm that this fixes the issue.

Committing to the MR was possible after I clicked on "Get push access" here in the issue and I also had to accept, that the commit goes to the default branch in the fork.

I'll have to do some more tests, then I can set this to NR.

I've now rebased the MR to the latest dev release and tested the solution successfully.

The main issue with the patch has been, that the file /dist/js/init.js contains trailing white space. When loading the patch into an IDE and saving it for local usage, that trailing space gets removed, and suddenly the patch no longer applies. That's probably a separate issue, but I'd suggest to clean up the code base such that trailing spaces get removed completely.

Awesome work, thanks Jürgen 👏

Automatically closed - issue fixed for 2 weeks with no activity.