- Issue created by @Ryo Yamashita
- last update
over 1 year ago 367 pass - @ryo-yamashita opened merge request.
- Status changed to Needs review
over 1 year ago 3:25am 15 September 2023 - Status changed to Needs work
over 1 year ago 3:32am 15 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the patch. Can you please take a look at the coding standards errors?
β https://git.drupalcode.org/issue/cloud-3387448/-/jobs/89527
Thanks
- last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 4:05am 15 September 2023 - Status changed to Needs work
over 1 year ago 8:10am 15 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. Can you please double-check the coding standards as follows?
FILE: .../html/web/modules/contrib/cloud/src/Controller/ApiController.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 185 | WARNING | Unused private method deleteCloudLaunchTemplate() 223 | WARNING | Unused private method launchCloudLaunchTemplate() 228 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead ----------------------------------------------------------------------
- last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 8:40am 15 September 2023 - Status changed to RTBC
over 1 year ago 9:23am 16 September 2023 @yas @ryo-yamashita
Thank you for providing the patch.
I checked the patch and it worked. Thanks.- πΊπΈUnited States yas California πΊπΈ
@asai.noriaki
Thank you for your review.
@ryo-yamashita
I ran the BDD tests (NOT for SPA), and the tests have been passed successfully. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. -
yas β
committed 0f934b6f on 6.x authored by
Ryo Yamashita β
Issue #3387448 by Ryo Yamashita, yas, asai.noriaki: Add the REST API to...
-
yas β
committed 0f934b6f on 6.x authored by
Ryo Yamashita β
-
yas β
committed 598a73a6 on 5.x authored by
Ryo Yamashita β
Issue #3387448 by Ryo Yamashita, yas, asai.noriaki: Add the REST API to...
-
yas β
committed 598a73a6 on 5.x authored by
Ryo Yamashita β
- Status changed to Fixed
over 1 year ago 2:21am 17 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.