12:00 is showing midnight/noon even when option not selected

Created on 14 September 2023, over 1 year ago

Problem/Motivation

There is a setting display_noon_and_midnight, but even though the setting value is captured, it is never checked in the logic. And the options between use all day and display noon/midnight cancel each other out. It's the logic that should determine which to display because it's based on the date in each field.

Steps to reproduce

Set a date with a time of 12:00:00 PM and do not select

Proposed resolution

Allow for both in configuration and check value of display_noon_and_midnight config setting.

Remaining tasks

[ ] Update config form state API for checked values in:

  • ApStyleDateFieldFormatter
  • ApStyleDateRangeFieldFormatter
  • DateAPStyleSettings

[ ] Update logic in ApStyleDateFormatter

User interface changes

Only the change in the state API for config forms

πŸ› Bug report
Status

Fixed

Version

1.5

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States shelane

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024