Add requestedAttributes to Metadata

NicklasMF → closed merge request !16

NicklasMF → reopened merge request !16

Thanks for the merge request. You're not missing anything; noone has asked for this before. And I wasn't aware of requestedAttributes.

(For the errors: you should just be able to make line 1033 if ($config->get('requested_attributes')) { I think. Also if you now open the form without having anything attributes configured, it's showing the same error on screen.)

I'm having initial thoughts that compete with this, and I'm not sure yet where they're going:

• When I initially saw your request, I figured it would be an extra argument for some 'additional_options' in settings.php mentioned in ✨ Possibility to add OneLogin config items like Contacts Active . Although on the other hand... you're proving out that things aren't all that hard to implement with the multivalue element, so maybe that one could also be implemented that way.
• I'm guessing that for many people, their requestedAttributes are equal to the fields they want to map using the samlauth_user_fields submodule. (Although I see how not all people that need requestedAttributes, want to use exactly this mapping.) So I'm kind-of wondering if we can prevent a duplicate list of attributes.

(And the samlauth_user_fields edit screen is not a multivalue thing, because

• i foresaw some kind of extension / things becoming unwieldy, at some point
• it means administrators need to do a lot of clicking, but hey, it's a one-time setup...