Contrib.social

Possibility to add OneLogin config items like Contacts

Open on Drupal.org →
Created on 14 September 2022, over 2 years ago
Updated 13 August 2023, over 1 year ago

Problem/Motivation

This module creates OneLogin Auth and translates settings from Drupal to that library. But there are options which cannot be added like Contact information: 

// Contact information template, it is recommended to supply a
    // technical and support contacts.
    'contactPerson' => array (
        'technical' => array (
            'givenName' => '',
            'emailAddress' => ''
        ),
        'support' => array (
            'givenName' => '',
            'emailAddress' => ''
        ),
    ),

Proposed resolution

If not in forms, make is possible to add options via settings.php:

$config['samlauth.authentication']['additional_options']['contactPerson'] = array (
        'technical' => array (
            'givenName' => '',
            'emailAddress' => ''
        ),
        'support' => array (
            'givenName' => '',
            'emailAddress' => ''
        ),
    );
✨ Feature request
Status

Active

Version

3.0

Component

Code

Created by

🇫🇮Finland back-2-95 Helsinki

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Looks like a valid feature request to me.

    This information is exposed in the SP's metadata XML. So it looks like this is good for IdPs that fetch the metadata and make use of it.

    This is not just a custom extension for OneLogin IdPs, given that a ContactPerson is defined in the saml-schema-metadata-2.0.xsd definition. There's more info: the library's Metadata::builder() code has details on what exactly is added to the metadata - which is not exactly all details that are documented in the XSD. And on where to add this into the initial settings array.

    I guess there's a case to be made for a 'additional_options' or 'metadata_add' configuration that can be set in settings,php, then merged (or deep-merged, with or without some checks).... combined with a mention in the README on how to use this + "use at your own risk",

  • First commit to issue fork.
  • Merge request !27Resolve #3309625 "Possibility to add" → (Open) created by mark_fullmer
  • Comment 3 days ago →
    🇺🇸United States mark_fullmer Tucson

    Given that the SAML spec only supports specific contactPerson and organization attributes, and that the php-saml library further only supports certain values within those attributes (see https://github.com/SAML-Toolkits/php-saml?tab=readme-ov-file#saml-php-to... ) -- in other words, there's no reason to support *arbitrary* values being passed into the metadata, I propose that we provide a UI for entering technical contact, support contact, and organization information.

    MR created.

  • Pipeline finished with Failed
    3 days ago
    Total: 156s
    #372743
  • Pipeline finished with Success
    3 days ago
    Total: 201s
    #372757
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024