- Issue created by @Greg Boggs
- Status changed to Needs review
about 1 year ago 7:49pm 11 September 2023 - @greg-boggs opened merge request.
- Status changed to RTBC
about 1 year ago 11:05pm 11 September 2023 - π΅πPhilippines kenyoOwen
Hi Greg Boggs
I reproduced the error, tested the patch, and confirmed that the issue is resolved when enabling the module. Please see the screenshots attached.
For your review.
Thank you. - π³π±Netherlands Ruuds
Thanks for reporting. While this patch fixes the issue for Drupal 10+ with PHP 8.x, would it possibly break the module on Drupal 9, as the definition of getSubscribedEvents() doesn't include a return parameter there?
- πΊπΈUnited States Greg Boggs Portland Oregon
It didn't break my Drupal 9 site. I'm guessing have a return type on there is still compatible, but having it missing is not.
-
Ruuds β
committed 90b40b61 on 2.0.x authored by
Greg Boggs β
Issue #3386559 by Greg Boggs: getSubscribedEvents() must be compatible
-
Ruuds β
committed 90b40b61 on 2.0.x authored by
Greg Boggs β
- Status changed to Fixed
about 1 year ago 8:49am 21 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.