1.0.0-beta6 adds enums for menu names for menuByName() query. As per graphql specs, a valid name should not start with a number. So, if there is any menu id/machine name which starts with number(for example, 1menu) this breaks the enum generation with error:
GraphQL\Error\SyntaxError: Syntax Error: Expected Name, found Int "1" in GraphQL\Language\Parser->expect() (line 366 of vendor/webonyx/graphql-php/src/Language/Parser.php).
The enum of menu names is being generated in graphql_core_schema\src\Plugin\GraphQL\SchemaExtension\MenuExtension::buildMenuNameEnum()
1. Create a menu with a name having digit as its first character. e.g. 1main
2. Create a graphql server and enable "Menu" extension.
3. Goto explorer tab to see the error.
To handle such cases, we can prefix the enum key with 'MENU_' .
--- a/src/Plugin/GraphQL/SchemaExtension/MenuExtension.php
+++ b/src/Plugin/GraphQL/SchemaExtension/MenuExtension.php
@@ -113,7 +113,7 @@ class MenuExtension extends SdlSchemaExtensionPluginBase implements CoreSchemaEx
/** @var \Drupal\system\Entity\Menu $menu */
$menu = $storage->load($id);
$key = strtoupper(str_replace('-', '_', $id));
- $values[$key] = [
+ $values['MENU_' . $key] = [
'value' => $key,
'description' => $menu->getDescription(),
];
@@ -152,8 +152,9 @@ class MenuExtension extends SdlSchemaExtensionPluginBase implements CoreSchemaEx
$builder->produce('entity_load')
->map('type', $builder->fromValue('menu'))
->map('id', $builder->callback(function ($value, $args) {
- // Convert the enum from MY_MENU_NAME to my-menu-name.
- return str_replace('_', '-', strtolower($args['name']));
+ // Convert the enum from MENU_MY_MENU_NAME to my-menu-name.
+ return str_replace('_', '-', strtolower(preg_replace('/^' . preg_quote('MENU_', '/') . '/', '', $args['name'])));
}))
);
- May be there is a better fix.
Fixed
1.0
Code
If I include the proposed patch, I would break all existing sites.
Therefore, I have adapted the code and only prefix the menu names if they start with a number.