- Issue created by @Ryo Yamashita
- last update
over 1 year ago 367 pass - @ryo-yamashita opened merge request.
- Status changed to Needs review
over 1 year ago 6:58am 11 September 2023 - Status changed to Needs work
over 1 year ago 7:45am 11 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the patch. I posted my comment. Thanks!
- last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 8:18am 11 September 2023 - Status changed to Needs work
over 1 year ago 8:31am 11 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. I found the indent problem. Can you please check it? Thanks
- last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 8:50am 11 September 2023 - last update
over 1 year ago Composer require failure - @ryo-yamashita opened merge request.
- last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - @ryo-yamashita opened merge request.
- Status changed to RTBC
over 1 year ago 8:53am 11 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - Status changed to Needs work
over 1 year ago 9:03am 11 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
I found the the following standards error. Can you please fix them? Thanks!
FILE: ...shboard/cloud_dashboard/src/organisms/LimitSummaryPanelBlock.tsx ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 32 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...d_dashboard/cloud_dashboard/src/organisms/LimitSummaryPanels.tsx ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 40 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------
- last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 9:24am 11 September 2023 - Status changed to RTBC
over 1 year ago 9:46am 11 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. It looks good to me now. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
over 1 year ago 367 pass -
yas β
committed 56714007 on 6.x authored by
Ryo Yamashita β
Issue #3386384 by Ryo Yamashita, yas: Add a block for the limit summary...
-
yas β
committed 56714007 on 6.x authored by
Ryo Yamashita β
- Status changed to Fixed
over 1 year ago 9:48am 11 September 2023 -
yas β
committed 65f15285 on 5.x authored by
Ryo Yamashita β
Issue #3386384 by Ryo Yamashita, yas: Add a block for the limit summary...
-
yas β
committed 65f15285 on 5.x authored by
Ryo Yamashita β
Automatically closed - issue fixed for 2 weeks with no activity.