Add an 'Edit' button to the OpenStack stack detailed view in SPA (drupal/cloud_dashboard)

Issue created by @Ryo Yamashita
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
@ryo-yamashita opened merge request.
Status changed to Needs review 10 months ago3:05am 11 September 2023
Comment 10 months ago →
🇯🇵Japan Ryo Yamashita
@yas

Please review it. Thanks.
Status changed to Needs work 10 months ago7:54am 11 September 2023
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Can you please rebase the patch due to the previous merge? Thanks

@asahi.noriaki @arutx-7557

What do you think?
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Status changed to Needs review 10 months ago8:08am 11 September 2023
Comment 10 months ago →
🇯🇵Japan Ryo Yamashita
Status changed to RTBC 10 months ago11:39am 11 September 2023
Comment 10 months ago →
asai.noriaki
@yas @ryo-yamashita

I tested the provided patch and it worked. Thanks.
Status changed to Needs work 10 months ago11:45am 11 September 2023
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@asai.noriaki

Thank you for your review.

@ryo-yamashita

Can you please rebase the patch due to the previous merge? Thanks!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
27:55
27:22
Running
Status changed to Needs review 10 months ago2:16am 12 September 2023
Comment 10 months ago →
🇯🇵Japan Ryo Yamashita
@yas

I rebased this patch. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Comment 10 months ago →
🇯🇵Japan Ryo Yamashita
@yas

I pushed new commits and rebased this issue.
As noted, the conversion process has been refactored to improve readability.
Thanks.
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@asai.noriaki

Thank you for your review.

@ryo-yamashita

Thank you for the update. It looks more cleaner. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Status changed to Needs work 10 months ago4:24am 13 September 2023
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Can you please rebase the patch due to the previous merge? Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
367 pass
Status changed to Needs review 10 months ago5:51am 13 September 2023
Comment 10 months ago →
🇯🇵Japan Ryo Yamashita
@yas

I rebased it again. Thanks.
Status changed to RTBC 10 months ago6:05am 13 September 2023
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Comment 10 months ago →
System Message

yas → committed 6608d51e on 6.x authored by Ryo Yamashita →
Issue #3386367 by Ryo Yamashita, yas, asai.noriaki: Add an 'Edit' button...
Comment 10 months ago →
🇺🇸United States yas California 🇺🇸
Status changed to Fixed 10 months ago6:07am 13 September 2023
Comment 10 months ago →
System Message

yas → committed f0175d91 on 5.x authored by Ryo Yamashita →
Issue #3386367 by Ryo Yamashita, yas, asai.noriaki: Add an 'Edit' button...
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Add an 'Edit' button to the OpenStack stack detailed view in SPA (drupal/cloud_dashboard)

Problem/Motivation

Comments & Activities