Comply with Drupal coding standards (2) (ESLint)

$ $CI_PROJECT_DIR/$_WEB_ROOT/core/node_modules/.bin/eslint --no-error-on-unmatched-pattern --ignore-pattern="*.es6.js" --resolve-plugins-relative-to=$CI_PROJECT_DIR/$_WEB_ROOT/core --ext=.js,.yml . || true /builds/project/rigel/web/modules/custom/rigel/Gruntfile.js 1:1 warning Missing JSDoc for parameter 'grunt' valid-jsdoc 5:18 warning Unexpected unnamed function func-names 15:17 error Insert `⏎··········` prettier/prettier 16:1 error Insert `··` prettier/prettier 17:11 error Insert `··` prettier/prettier 18:1 error Insert `··` prettier/prettier 19:11 error Insert `··` prettier/prettier 20:11 error Replace `ext:·'.css'` with `··ext:·'.css',` prettier/prettier 21:1 error Replace `········}]` with `··········},⏎········],` prettier/prettier 22:8 error Insert `,` prettier/prettier 24:14 error Delete `·` prettier/prettier 28:27 error Insert `,` prettier/prettier 30:13 error Replace `⏎········'assets/css/main.css'⏎······]` with `'assets/css/main.css'],` prettier/prettier 40:6 error Insert `,` prettier/prettier 41:5 error Insert `;` prettier/prettier 46:34 error Replace `⏎····'watch'⏎··` with `'watch'` prettier/prettier 49:1 error Replace `⏎}⏎` with `};` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/js/button-effect.js 4:24 warning Unexpected unnamed function func-names 8:2 warning Unexpected unnamed function func-names 9:28 warning Unexpected unnamed function func-names 10:5 error Split 'var' declarations into multiple statements one-var 10:5 error Unexpected var, use let or const instead no-var 14:25 warning Unexpected unnamed function func-names 18:9 error Insert `·` prettier/prettier 22:9 error Insert `·` prettier/prettier 31:19 error Replace `'width':·size,·'height':·size` with `·width:·size,·height:·size·` prettier/prettier 33:17 error Missing radix parameter radix 33:58 error Replace `(size·/·2)` with `size·/·2` prettier/prettier 34:17 error Missing radix parameter radix 34:57 error Replace `(size·/·2)` with `size·/·2` prettier/prettier 36:13 error Replace `.css({·'top':·rippleY·+·'px',·'left':·rippleX·+·'px'·})` with `⏎········.css({·top:·rippleY·+·'px',·left:·rippleX·+·'px'·})⏎········` prettier/prettier 36:27 error Unexpected string concatenation prefer-template 36:51 error Unexpected string concatenation prefer-template 38:18 warning Unexpected unnamed function func-names 41:1 error Delete `⏎` prettier/prettier 44:2 error Replace `(jQuery)` with `)(jQuery` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/js/dropdown.js 7:2 warning Unexpected unnamed function func-names 8:1 error Delete `⏎` prettier/prettier 10:26 error Replace `'.custom-dropdown·>·button.uparrow',` with `·'.custom-dropdown·>·button.uparrow',·` prettier/prettier 10:62 warning Unexpected unnamed function func-names 13:50 warning Unexpected unnamed function func-names 14:7 error Unexpected var, use let or const instead no-var 14:32 error Replace `"span"` with `'span'` prettier/prettier 18:6 error Delete `⏎` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/js/global.js 8:2 warning Unexpected unnamed function func-names 9:3 error 'use strict' is unnecessary inside of modules strict 12:5 warning Unexpected unnamed method 'attach' func-names 12:5 error Expected method shorthand object-shorthand 13:7 error Unexpected var, use let or const instead no-var 14:7 error Unexpected var, use let or const instead no-var 15:49 warning Unexpected unnamed function func-names 16:9 error Unexpected var, use let or const instead no-var 17:9 error Unexpected var, use let or const instead no-var 18:17 error Replace `.find('select[name="navbar_position"]')` with `⏎··········.find('select[name="navbar_position"]')⏎··········` prettier/prettier 18:72 warning Unexpected unnamed function func-names 19:1 error Insert `··` prettier/prettier 19:11 error Unexpected var, use let or const instead no-var 20:11 error Replace `$navbar.removeClass('navbar-fixed-bottom·navbar-fixed-top·navbar-static-top·container'` with `··$navbar.removeClass(⏎··············'navbar-fixed-bottom·navbar-fixed-top·navbar-static-top·container',⏎············` prettier/prettier 21:1 error Insert `··` prettier/prettier 22:1 error Insert `··` prettier/prettier 22:30 error Unexpected string concatenation prefer-template 23:11 error Replace `}⏎·········` with `··}` prettier/prettier 25:13 error Insert `··` prettier/prettier 26:1 error Insert `··` prettier/prettier 28:11 error Insert `··` prettier/prettier 29:1 error Replace `··········$body.removeClass('navbar-is-fixed-top·navbar-is-fixed-bottom·navbar-is-static-top'` with `············$body.removeClass(⏎··············'navbar-is-fixed-top·navbar-is-fixed-bottom·navbar-is-static-top',⏎············` prettier/prettier 30:1 error Replace `··········` with `············` prettier/prettier 30:11 error Expected a default case default-case 31:13 error Insert `··` prettier/prettier 32:1 error Insert `··` prettier/prettier 33:15 error Insert `··` prettier/prettier 35:1 error Replace `············` with `··············` prettier/prettier 36:1 error Insert `··` prettier/prettier 37:15 error Insert `··` prettier/prettier 39:1 error Insert `··` prettier/prettier 40:15 error Insert `··` prettier/prettier 41:15 error Insert `··` prettier/prettier 42:1 error Insert `··` prettier/prettier 43:9 error Insert `··` prettier/prettier 44:17 error Replace `.find('input[name="navbar_inverse"]')` with `⏎··········.find('input[name="navbar_inverse"]')⏎··········` prettier/prettier 44:70 warning Unexpected unnamed function func-names 45:1 error Insert `··` prettier/prettier 46:1 error Insert `··` prettier/prettier 50:75 error Replace `'.right-sec-wrapper'` with `⏎········'.right-sec-wrapper',⏎······` prettier/prettier 52:45 error Replace `'nav[aria-labelledby="block-rigel-account-menu-menu"]'` with `⏎········'nav[aria-labelledby="block-rigel-account-menu-menu"]',⏎······` prettier/prettier 53:9 error Replace `'.breadcrumb-wrapper,·nav[aria-labelledby="block-rigel-account-menu-menu"]'` with `⏎········'.breadcrumb-wrapper,·nav[aria-labelledby="block-rigel-account-menu-menu"]',⏎······` prettier/prettier 58:24 warning Unexpected unnamed function func-names 88:57 warning Unexpected unnamed function func-names 89:42 error Replace `'<span·class="caret·downarrow"></span>'` with `⏎··········'<span·class="caret·downarrow"></span>',⏎········` prettier/prettier 91:56 warning Unexpected unnamed function func-names 96:9 error Replace `once('form_actions',·'form·.form-actions·input[value="Apply·to·selected·items"]',·context)` with `⏎········once(⏎··········'form_actions',⏎··········'form·.form-actions·input[value="Apply·to·selected·items"]',⏎··········context,⏎········),⏎······` prettier/prettier 96:106 warning Unexpected unnamed function func-names 97:22 error Replace `'<div·class="btn·btn-primary·btn-wrap·apply-btn·ripple-effect"·/>'` with `⏎··········'<div·class="btn·btn-primary·btn-wrap·apply-btn·ripple-effect"·/>',⏎········` prettier/prettier 99:75 error Insert `⏎········` prettier/prettier 99:75 warning Unexpected unnamed function func-names 100:1 error Insert `··` prettier/prettier 101:7 error Replace `}` with `··},⏎······` prettier/prettier 104:9 error Replace `once('form_submit',·'#k8s-namespace-costs·.details-wrapper·.form-submit',·context)` with `⏎········once(⏎··········'form_submit',⏎··········'#k8s-namespace-costs·.details-wrapper·.form-submit',⏎··········context,⏎········),⏎······` prettier/prettier 104:98 warning Unexpected unnamed function func-names 105:22 error Replace `'<div·class="btn·btn-primary·btn-wrap·apply-btn·ripple-effect"·/>'` with `⏎··········'<div·class="btn·btn-primary·btn-wrap·apply-btn·ripple-effect"·/>',⏎········` prettier/prettier 108:9 error Replace `once('k8s_apply_btn',·'#k8s-namespace-costs·.details-wrapper·.apply-btn',·context)` with `⏎········once(⏎··········'k8s_apply_btn',⏎··········'#k8s-namespace-costs·.details-wrapper·.apply-btn',⏎··········context,⏎········),⏎······` prettier/prettier 108:98 warning Unexpected unnamed function func-names 116:37 warning Unexpected unnamed function func-names 121:48 warning Unexpected unnamed function func-names 121:61 error Delete `⏎` prettier/prettier 128:13 error 'currentTab' is never reassigned. Use 'const' instead prefer-const 136:52 warning Unexpected unnamed function func-names 144:9 error All 'var' declarations must be at the top of the function scope vars-on-top 144:9 error Unexpected var, use let or const instead no-var 145:9 error All 'var' declarations must be at the top of the function scope vars-on-top 145:9 error Unexpected var, use let or const instead no-var 154:63 warning Unexpected unnamed function func-names 160:7 error All 'var' declarations must be at the top of the function scope vars-on-top 160:7 error Unexpected var, use let or const instead no-var 160:46 error Replace `document.querySelectorAll('[data-bs-toggle="tooltip"]'))` with `⏎········document.querySelectorAll('[data-bs-toggle="tooltip"]'),⏎······);` prettier/prettier 161:7 error All 'var' declarations must be at the top of the function scope vars-on-top 161:7 error Unexpected var, use let or const instead no-var 161:11 warning 'tooltipList' is assigned a value but never used no-unused-vars 161:48 warning Unexpected unnamed function func-names 162:20 error 'bootstrap' is not defined no-undef 162:55 error Insert `;` prettier/prettier 164:1 error Replace `⏎····}` with `····},` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/js/menu.js 5:2 warning Unexpected unnamed function func-names 6:3 error 'use strict' is unnecessary inside of modules strict 6:3 error Expected newline after "use strict" directive lines-around-directive 8:5 warning Unexpected unnamed method 'attach' func-names 8:5 error Expected method shorthand object-shorthand 9:1 error Delete `⏎` prettier/prettier 11:69 error Replace `'click',` with `⏎········'click',⏎·······` prettier/prettier 11:78 warning Unexpected unnamed function func-names 11:88 warning 'e' is defined but never used no-unused-vars 12:1 error Insert `··` prettier/prettier 12:13 error '$el' is never reassigned. Use 'const' instead prefer-const 13:1 error Insert `··` prettier/prettier 13:13 error '$parent' is never reassigned. Use 'const' instead prefer-const 14:1 error Replace `········` with `··········` prettier/prettier 16:1 error Insert `··` prettier/prettier 17:11 error Replace `$el.next().css({·'top':·$el[0].offsetTop,·'left'` with `··$el⏎··············.next()⏎··············.css({·top:·$el[0].offsetTop,·left` prettier/prettier 18:9 error Insert `··` prettier/prettier 19:1 error Insert `··` prettier/prettier 20:1 error Replace `········` with `··········` prettier/prettier 21:7 error Replace `}` with `··},⏎······` prettier/prettier 25:64 error Replace `'click',` with `⏎········'click',⏎·······` prettier/prettier 25:73 warning Unexpected unnamed function func-names 25:83 warning 'e' is defined but never used no-unused-vars 26:9 error Insert `··` prettier/prettier 27:1 error Insert `··` prettier/prettier 28:1 error Replace `········$('#navbar-collapse').toggleClass('active')` with `··········$('#navbar-collapse')⏎············.toggleClass('active')⏎············` prettier/prettier 29:1 error Insert `··` prettier/prettier 30:7 error Replace `}` with `··},⏎······` prettier/prettier 32:25 warning Unexpected unnamed function func-names 33:9 error Unexpected var, use let or const instead no-var 33:13 error Use object destructuring prefer-destructuring 36:21 error Replace `.parents().is('.navbar·a.dropdown-toggle,·.navbar·.navbar-toggler')` with `⏎············.parents()⏎············.is('.navbar·a.dropdown-toggle,·.navbar·.navbar-toggler')⏎········` prettier/prettier 44:7 error All 'var' declarations must be at the top of the function scope vars-on-top 44:7 error Unexpected var, use let or const instead no-var 46:7 error All 'var' declarations must be at the top of the function scope vars-on-top 46:7 error Unexpected var, use let or const instead no-var 46:11 error Identifier 'base_url' is not in camel case camelcase 47:7 error All 'var' declarations must be at the top of the function scope vars-on-top 47:7 error Unexpected var, use let or const instead no-var 47:19 error Identifier 'base_url' is not in camel case camelcase 49:34 warning Unexpected unnamed function func-names 50:9 error Unexpected var, use let or const instead no-var 51:9 error Unexpected var, use let or const instead no-var 51:24 error Identifier 'base_url' is not in camel case camelcase 52:9 error Unexpected var, use let or const instead no-var 53:19 error Expected '===' and instead saw '==' eqeqeq 54:1 error Delete `⏎` prettier/prettier 65:1 error Replace `⏎····}` with `····},` prettier/prettier 67:4 error Insert `;` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/js/nav-tabs.js 1:1 error Expected space or tab before '*/' in comment spaced-comment 2:1 error Insert `·` prettier/prettier 3:1 error Insert `·` prettier/prettier 4:1 error Insert `·` prettier/prettier 5:1 error Insert `·` prettier/prettier 6:1 error Insert `·` prettier/prettier 8:2 warning Unexpected unnamed function func-names 10:5 error Unexpected var, use let or const instead no-var 11:5 error Unexpected var, use let or const instead no-var 13:5 error Unexpected var, use let or const instead no-var 15:7 error All 'var' declarations must be at the top of the function scope vars-on-top 15:7 error Unexpected var, use let or const instead no-var 16:37 warning Unexpected unnamed function func-names 26:12 error Replace `'nav-tabs',·'[data-drupal-nav-tabs].is-collapsible',·context` with `⏎········'nav-tabs',⏎········'[data-drupal-nav-tabs].is-collapsible',⏎········context,⏎······` prettier/prettier 26:82 warning Unexpected unnamed function func-names 29:6 error Insert `,` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/js/rigel.js 5:2 warning Unexpected unnamed function func-names 6:3 error 'use strict' is unnecessary inside of modules strict 6:3 error Expected newline after "use strict" directive lines-around-directive 8:5 warning Unexpected unnamed method 'attach' func-names 8:5 error Expected method shorthand object-shorthand 9:1 error Replace `⏎······let·font_family·=·(drupalSettings.rigel.font_family·===·null)·?·'Lucida·Grande'` with `······let·font_family·=⏎········drupalSettings.rigel.font_family·===·null⏎··········?·'Lucida·Grande'⏎·········` prettier/prettier 10:11 error Identifier 'font_family' is not in camel case camelcase 10:11 error 'font_family' is never reassigned. Use 'const' instead prefer-const 12:23 error Replace `.find('strong').siblings('span').html('Theme:·'·+·'Dark'·+·'<br·/>·'·+·'Font·family:·'·+·font_family·+·'<br·/>·'·+·'Font·size:·'·+·'Medium'` with `⏎········.find('strong')⏎········.siblings('span')⏎········.html(⏎··········'Theme:·'·+⏎············'Dark'·+⏎············'<br·/>·'·+⏎············'Font·family:·'·+⏎············font_family·+⏎············'<br·/>·'·+⏎············'Font·size:·'·+⏎············'Medium',⏎········` prettier/prettier 12:61 error Unexpected string concatenation prefer-template 12:71 error Unexpected string concatenation of literals no-useless-concat 12:80 error Unexpected string concatenation of literals no-useless-concat 12:92 error Unexpected string concatenation of literals no-useless-concat 12:112 error Identifier 'font_family' is not in camel case camelcase 12:136 error Unexpected string concatenation of literals no-useless-concat 12:152 error Unexpected string concatenation of literals no-useless-concat 14:37 warning Unexpected unnamed function func-names 17:13 error Identifier 'font_family_value' is not in camel case camelcase 19:13 error Identifier 'font_family_value' is not in camel case camelcase 19:41 error Identifier 'font_family_value' is not in camel case camelcase 20:11 error Identifier 'font_family_value' is not in camel case camelcase 24:25 error Replace `.find('strong').siblings('span').html('Theme:·'·+·'Dark'·+·'<br·/>·'·+·'Font·family:·'·+·font_family_value·+·'<br·/>·'·+·'Font·size:·'·+·'Medium'` with `⏎··········.find('strong')⏎··········.siblings('span')⏎··········.html(⏎············'Theme:·'·+⏎··············'Dark'·+⏎··············'<br·/>·'·+⏎··············'Font·family:·'·+⏎··············font_family_value·+⏎··············'<br·/>·'·+⏎··············'Font·size:·'·+⏎··············'Medium',⏎··········` prettier/prettier 24:63 error Unexpected string concatenation prefer-template 24:73 error Unexpected string concatenation of literals no-useless-concat 24:82 error Unexpected string concatenation of literals no-useless-concat 24:94 error Unexpected string concatenation of literals no-useless-concat 24:114 error Identifier 'font_family_value' is not in camel case camelcase 24:144 error Unexpected string concatenation of literals no-useless-concat 24:160 error Unexpected string concatenation of literals no-useless-concat 25:115 error Delete `⏎` prettier/prettier 30:11 error Identifier 'body_font_family' is not in camel case camelcase 30:11 error 'body_font_family' is never reassigned. Use 'const' instead prefer-const 31:11 error Identifier 'replace_body_font_family' is not in camel case camelcase 31:11 error 'replace_body_font_family' is never reassigned. Use 'const' instead prefer-const 31:38 error Unexpected string concatenation prefer-template 31:44 error Identifier 'body_font_family' is not in camel case camelcase 31:70 error Unnecessary escape character: \" no-useless-escape 32:11 error Identifier 'font_family_array' is not in camel case camelcase 32:11 error 'font_family_array' is never reassigned. Use 'const' instead prefer-const 32:31 error Identifier 'replace_body_font_family' is not in camel case camelcase 34:11 error Identifier 'font_family' is not in camel case camelcase 36:13 error 'index' is never reassigned. Use 'const' instead prefer-const 36:21 error Identifier 'font_family_array' is not in camel case camelcase 36:47 error Unexpected string concatenation prefer-template 36:53 error Identifier 'font_family' is not in camel case camelcase 38:12 error Identifier 'font_family_array' is not in camel case camelcase 38:34 error Identifier 'font_family_array' is not in camel case camelcase 38:63 error Replace `font_family_array[index],·font_family_array[0]` with `⏎············font_family_array[index],⏎············font_family_array[0],⏎··········` prettier/prettier 38:63 error Identifier 'font_family_array' is not in camel case camelcase 38:89 error Identifier 'font_family_array' is not in camel case camelcase 43:11 error Identifier 'updated_font_family' is not in camel case camelcase 43:11 error 'updated_font_family' is never reassigned. Use 'const' instead prefer-const 43:33 error Identifier 'font_family_array' is not in camel case camelcase 45:11 error Identifier 'updated_font_family' is not in camel case camelcase 48:6 error Insert `,` prettier/prettier 49:4 error Insert `;` prettier/prettier 53:5 warning Unexpected unnamed method 'attach' func-names 53:5 error Expected method shorthand object-shorthand 54:11 error Identifier 'video_src' is not in camel case camelcase 55:25 warning Unexpected unnamed function func-names 56:9 error Identifier 'video_src' is not in camel case camelcase 60:40 warning Unexpected unnamed function func-names 60:50 warning 'e' is defined but never used no-unused-vars 65:39 warning Unexpected unnamed function func-names 65:49 warning 'e' is defined but never used no-unused-vars 68:6 error Insert `,` prettier/prettier 69:4 error Replace `⏎` with `;` prettier/prettier /builds/project/rigel/web/modules/custom/rigel/rigel.libraries.yml 18:1 error Expected indentation of 2 spaces but found 0 spaces yml/indent ✖ 255 problems (207 errors, 48 warnings) 156 errors and 0 warnings potentially fixable with the `--fix` option.

Comments & Activities

Issue created by @yas
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Assigned to shubham_jain
Comment over 1 year ago →
🇮🇳India shubham_jain
Comment about 1 year ago →
🇮🇳India shubham_jain
Hi @yas, can you share your .eslintrc.json file.
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@shubham_jain

I have .eslintrc.json file. The ESLint test should be run on d.o's GitLab CI. Thanks
Comment about 1 year ago →
🇮🇳India shubham_jain
Hi @yas, I know that the ESLint test should be run on d.o's GitLab CI. But I need it because to setup my .eslintrc.json file to get those errors in my local and find line directly in VS Code. Otherwise, I will have to search for each error line here and solve that in my local which will be time consuming.
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@shubham_jain

In that sense, again, I think we have no .eslintrc.json file. You can learn about how GitLab CI works:

https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

https://git.drupalcode.org/project/gitlab_templates/

💬 Add a .gitlab-ci.yml file Needs work includes .gitlab-ci.yml. Note that I'm testing your Stylelint patch at that issue, so please get only .gitlab-ci.yml file from the MR !41
Comment about 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
Xiaohua Guan → made their first commit to this issue’s fork.
@xiaohua-guan opened merge request.
Status changed to Needs review about 1 year ago5:43am 18 October 2023
Comment about 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
Comment about 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
@yas

Please take a look. Thanks.
Status changed to Needs work about 1 year ago8:39am 18 October 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the patch. I posted my comments. Thanks!
Status changed to Needs review about 1 year ago9:20am 18 October 2023
Comment about 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
Status changed to Needs work about 1 year ago9:27am 18 October 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. I posted my comments. Thanks!
Assigned to xiaohua guan
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
Status changed to Needs review about 1 year ago1:03am 19 October 2023
Comment about 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
@yas

Please take a look. Thanks.
Status changed to RTBC about 1 year ago1:26pm 19 October 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. It looks good to me now. I'll merge the patch to 6.x, and close this issue as Fixed.
Comment about 1 year ago →
System Message

yas → committed df684cff on 6.x authored by Xiaohua Guan →
Issue #3386283 by Xiaohua Guan, yas: Comply with Drupal coding standards...
Status changed to Fixed about 1 year ago1:26pm 19 October 2023
Comment about 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Comply with Drupal coding standards (2) (ESLint)

Problem/Motivation

Comments & Activities