Problem/Motivation
After emails are sent via a custom email handler that sends separate emails, this deprecated function error is being thrown:
Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->getElementKeyFromToken() (line 1764 of modules/contrib/webform/src/Plugin/WebformHandler/EmailWebformHandler.php).
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->getElementKeyFromToken(NULL) (Line: 991)
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->getMessageEmails(Object, 'cc', NULL) (Line: 917)
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->getMessage(Object) (Line: 73)
Drupal\ovc_ncvrw_webform\Plugin\WebformHandler\OjpSendMultipleEmailWebformHandler->postSave(Object, 1, NULL) (Line: 2757)
Drupal\webform\Entity\Webform->invokeHandlers('postSave', Object, 1, NULL) (Line: 1212)
Drupal\webform\WebformSubmissionStorage->invokeWebformHandlers('postSave', Object, 1) (Line: 1120)
Drupal\webform\WebformSubmissionStorage->doPostSave(Object, 1) (Line: 523)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 804)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 983)
Drupal\webform\WebformSubmissionStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 901)
Drupal\webform\Entity\WebformSubmission->save() (Line: 1995)
Drupal\webform\WebformSubmissionForm->save(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('webform_submission_nomination_node_55421_edit_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
The email handler is based on the contrib module
Webform Send Multiple Emails →
. Since I need a unique query string parameter value in each email, I'm adapting the handler. Here is the handler:
<?php
namespace Drupal\my_module\Plugin\WebformHandler;
use Drupal\Core\Form\FormStateInterface;
use Drupal\webform\WebformSubmissionInterface;
use Drupal\webform\Plugin\WebformHandler\EmailWebformHandler;
/**
* Sends an email to recipients individually.
*
* @WebformHandler(
* id = "send_multiple_emails",
* label = @Translation("Send Multiple Emails"),
* category = @Translation("Notification"),
* description = @Translation("Sends an email to recipients individually."),
* cardinality = \Drupal\webform\Plugin\WebformHandlerInterface::CARDINALITY_UNLIMITED,
* results = \Drupal\webform\Plugin\WebformHandlerInterface::RESULTS_PROCESSED,
* submission = \Drupal\webform\Plugin\WebformHandlerInterface::SUBMISSION_OPTIONAL,
* )
*/
class SendMultipleEmailWebformHandler extends EmailWebformHandler {
/**
* {@inheritdoc}
*/
public function getSummary() {
$markup = $this->t('<strong>To</strong>: @to', ['@to' => $this->configuration['to_mail']]) . '<br />';
$markup .= $this->t('<strong>From</strong>: @from_mail', ['@from_mail' => $this->configuration['from_mail']]) . '<br />';
$markup .= $this->t('<strong>Reply to</strong>: @reply_to', ['@reply_to' => $this->configuration['reply_to']]) . '<br />';
$markup .= $this->t('<strong>Subject</strong>: @subject', ['@subject' => $this->configuration['subject']]) . '<br />';
$html = $this->configuration['html'] ? 'HTML' : '';
$markup .= $this->t('<strong>Settings</strong>: @settings', ['@settings' => $html]) . '<br />';
$states = ucfirst($this->configuration['states'][0]);
$markup .= $this->t('<strong>Sent when</strong>: @sent', ['@sent' => $states]) . '<br />';
return [
'#theme' => 'markup',
'#markup' => $markup,
];
}
/**
* {@inheritdoc}
*/
public function buildConfigurationForm(array $form, FormStateInterface $form_state) {
$form = parent::buildConfigurationForm($form, $form_state);
// Disable cc, bcc fields to prevent sending same email multiple times to these.
$form['to']['cc_mail']['cc_mail']['#access'] = FALSE;
$form['to']['bcc_mail']['bcc_mail']['#access'] = FALSE;
return $form;
}
/**
* {@inheritdoc}
*/
public function postSave(WebformSubmissionInterface $webform_submission, $update = TRUE) {
$state = $webform_submission->getWebform()
->getSetting('results_disabled') ? WebformSubmissionInterface::STATE_COMPLETED : $webform_submission->getState();
if ($this->configuration['states'] && in_array($state, $this->configuration['states'])) {
$message = $this->getMessage($webform_submission);
$to_mail_list = explode(',', $message['to_mail']);
foreach ($to_mail_list as $to_mail) {
$message['to_mail'] = $to_mail;
$this->sendMessage($webform_submission, $message);
}
}
}
}
The computed twig element to create a comma separated list of email addresses is this:
{% set reviewer_0 = webform_token('[webform_submission:values:reviewer:0:entity:mail:clear]', webform_submission, [], options) %}
{% set reviewer_1 = webform_token('[webform_submission:values:reviewer:1:entity:mail:clear]', webform_submission, [], options) %}
{% set reviewer_2 = webform_token('[webform_submission:values:reviewer:2:entity:mail:clear]', webform_submission, [], options) %}
{% if reviewer_0|length %}{{ reviewer_0 }}{% else %}{% endif %}
{% if reviewer_1|length %},{{ reviewer_1 }}{% else %}{% endif %}
{% if reviewer_2|length %},{{ reviewer_2 }}{% else %}{% endif %}
With Remove whitespace around the "computed value and between HTML tags", and "Automatically update the computed value using Ajax".
reviewer is an Entity select element restricted to the role of reviewer.
A Radios element with option values No and Yes is also added, so the site manager can select Yes after they have reviewed the submission and are ready to notify the reviewers via email.
Steps to reproduce
Add handler to the form.
Add Entity select element to the form.
Add Computed twig element to the form.
Add Radios element to the form.
Create a submission.
Edit the result.
Select Yes to "Email Reviewers"
Save the form.
Emails go out, and
Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->getElementKeyFromToken() (line 1764 of modules/contrib/webform/src/Plugin/WebformHandler/EmailWebformHandler.php).
is thrown.
Note, the error is only being thrown when using the custom handler.
Proposed resolution
Add null coalescing operator to /webform/src/Plugin/WebformHandler/EmailWebformHandler.php line 1764.
Remaining tasks
Add patch and MR, if change is approved.
User interface changes
None
API changes
None
Data model changes
None