- Issue created by @Krypton
- last update
almost 2 years ago 534 pass - @krypton opened merge request.
- Status changed to Needs review
almost 2 years ago 1:13pm 8 September 2023 - last update
almost 2 years ago 534 pass - @krypton opened merge request.
- 🇺🇦Ukraine gilmord 🇺🇦Ukraine
I got this notice when running tests, merge request !358 fixed it for me.
+1 for this to be merged - Status changed to RTBC
almost 2 years ago 5:12pm 8 September 2023 - Status changed to Needs work
almost 2 years ago 7:33pm 10 September 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
We need to document how to replicate and fix the issue.
- 🇺🇦Ukraine gilmord 🇺🇦Ukraine
@jrockowitz not sure what kind of document is required, please give more details on it
As about how to replicate and fix the issue:
- Replicate: metatag_tokens() triggers hook_metatags_alter(), hook_tokens can be invoked by Drush (f.e. update hook to resave entites), so there is no route in this case
- Fix: make sure $route_name is not NULL in webform_metatags_alter() before using it - 🇺🇸United States jrockowitz Brooklyn, NY
The MR is changing a massive amount of code.
https://git.drupalcode.org/project/webform/-/merge_requests/358.diffThe MR should only include the required changes.
- 🇺🇦Ukraine gilmord 🇺🇦Ukraine
@jrockowitz looks like there are two MTs for some reason, this one looks fine:
https://git.drupalcode.org/project/webform/-/merge_requests/359/diffs - 187f351e committed on 6.2.x
Issue #3386119 by Krypton: Added is null route check
- 187f351e committed on 6.2.x
- Status changed to Fixed
almost 2 years ago 7:02pm 11 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.