Cookie base path not check in the test but set in code

Note how the issue is fixed here https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/j... after applying the same change that is in the MR.

This is a fix to the test, the code is totally fine.
The MR is here: https://git.drupalcode.org/project/drupal/-/merge_requests/4723/diffs

We've been setting the issues that are blockers for GitlabCI as critical.
Please review.

I have checked this and yes, the Drupal.toolbar.collapsed is being set on two places:

1. in toolbar.js (two times)
2. in toolbar_toggle_page

On both places the base_path is used when setting the cookie. So it seems to be correct that the testToolbarCollapsedCookie() should use the base_path instead of hardcoded forward slash as well.

D7 on DrupalCI does not seems to run in a subdirectory (see the snippet from DrupalCI console: You are about to create a /var/www/html/sites/default/settings.php file and DROP all tables in your 'jenkins_drupal_d7_274437' database.), so this is probably the case why this was not failing in tests until now.

The changes looks good to me and passes all tests, so moving to RTBC. Thanks!

This makes sense; I think it's ready to commit. Thanks!

Committed, thanks everyone!

poker10 → closed merge request !4723

Automatically closed - issue fixed for 2 weeks with no activity.