- Issue created by @fjgarlin
- Open on Drupal.org βEnvironment: PHP 8.1 & MySQL 5.7last update
12 months ago Not currently mergeable. - @fjgarlin opened merge request.
- last update
12 months ago 2,160 pass - Status changed to Needs review
12 months ago 7:56am 8 September 2023 - πͺπΈSpain fjgarlin
Note how the issue is fixed here https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/j... after applying the same change that is in the MR.
This is a fix to the test, the code is totally fine.
The MR is here: https://git.drupalcode.org/project/drupal/-/merge_requests/4723/diffsWe've been setting the issues that are blockers for GitlabCI as critical.
Please review. - last update
12 months ago 2,156 pass - last update
12 months ago 2,160 pass - last update
12 months ago 2,121 pass - Status changed to RTBC
12 months ago 10:01am 8 September 2023 - πΈπ°Slovakia poker10
I have checked this and yes, the
Drupal.toolbar.collapsed
is being set on two places:1. in
toolbar.js
(two times)
2. intoolbar_toggle_page
On both places the
base_path
is used when setting the cookie. So it seems to be correct that thetestToolbarCollapsedCookie()
should use thebase_path
instead of hardcoded forward slash as well.D7 on DrupalCI does not seems to run in a subdirectory (see the snippet from DrupalCI console:
You are about to create a /var/www/html/sites/default/settings.php file and DROP all tables in your 'jenkins_drupal_d7_274437' database.
), so this is probably the case why this was not failing in tests until now.The changes looks good to me and passes all tests, so moving to RTBC. Thanks!
- last update
12 months ago 2,160 pass - last update
12 months ago 2,160 pass - last update
12 months ago 2,160 pass - last update
12 months ago 2,160 pass - last update
12 months ago 2,160 pass - last update
12 months ago 2,121 pass - last update
12 months ago 2,160 pass - π¬π§United Kingdom mcdruid π¬π§πͺπΊ
This makes sense; I think it's ready to commit. Thanks!
-
poker10 β
committed 605b36bd on 7.x
Issue #3386055 by fjgarlin: Cookie base path not check in the test but...
-
poker10 β
committed 605b36bd on 7.x
- Status changed to Fixed
12 months ago 11:02pm 11 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.