- Issue created by @rszrama
- 🇺🇦Ukraine marchuk.vitaliy Rivne, UA
vmarchuk → made their first commit to this issue’s fork.
- last update
12 months ago 37 pass, 2 fail - @vmarchuk opened merge request.
- last update
12 months ago 37 pass, 2 fail - last update
12 months ago 38 pass - Status changed to Needs review
12 months ago 2:51pm 9 October 2023 - Status changed to Needs work
12 months ago 3:44am 11 October 2023 - 🇺🇸United States rszrama
I've reviewed this and think it needs a little work.
Ultimately, I think we should not keep the "Enable credit card icons" field on the form. It's confusing to have to check that checkbox in order to activate showing payment method logos, even though "No" is an option in the select list. In other words, when the form is rendered and there is a value for the old setting, it should be used to set the values of the new settings in an equivalent fashion ... but we shouldn't be trying to preserve and interpret the checkbox after this update.
- last update
12 months ago 38 pass - last update
12 months ago 38 pass - Status changed to Needs review
12 months ago 8:21am 11 October 2023 - 🇺🇦Ukraine marchuk.vitaliy Rivne, UA
@rszrama
Ultimately, I think we should not keep the "Enable credit card icons" field on the form. It's confusing to have to check that checkbox in order to activate showing payment method logos, even though "No" is an option in the select list. In other words, when the form is rendered and there is a value for the old setting, it should be used to set the values of the new settings in an equivalent fashion ... but we shouldn't be trying to preserve and interpret the checkbox after this update.
It's done. I also updated the settings to set the default credit cards for backwards compatibility. This means that if someone after updating the module opens the payment gateway settings form and then just clicks "Save", we will keep the existing behavior but with the new settings.